[IP-126]: implement peppol#339
Closed
nielsdrost7 wants to merge 444 commits intoold-develop-branchfrom
Closed
Conversation
* chore(deps): update Composer dependencies (all-dependencies) * Fix composer-update workflow to emit paired package names and versions with categorization (#321) * Initial plan * fix: parse composer.lock JSON directly for proper name:version pairing Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * perf: optimize package comparison with O(n) array lookups instead of O(n²) loops Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * feat: split package changes by direct vs transient dependencies Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * fix: add error handling for composer.json parsing Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
* Initial plan * Fix date assertion format in PaymentsTest and ProjectsTest Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
…325) * Initial plan * Replace MySQL FIELD() with SQLite-compatible CASE for task status ordering Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
* Initial plan * Remove timestamp from PHPStan report artifact Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
…and services (#324) * Initial plan * fix: resolve PHPStan float array key errors in Peppol format handlers Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * fix: resolve remaining 32 PHPStan errors across tests and services Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * docs: enhance PHPStan type safety guidelines to prevent common errors Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * fix: accept string|ReportTemplateType for backward compatibility The createTemplate method now accepts both string and ReportTemplateType enum to maintain backward compatibility with existing callers that pass strings. When a string is provided, it's converted to the enum using ReportTemplateType::from(). Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * refactor: improve PHPStan type hints and remove suppressions - Replace PHPStan suppression in ListTasks.php with proper @var Builder docblock - Change ReportTemplateResource::$navigationGroup to string|UnitEnum|null for consistency with other resources - Add UnitEnum import to ReportTemplateResource.php Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
…omplete markers (#327) * Initial plan * fix: resolve PHPStan float array key errors in Peppol format handlers Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * fix: resolve remaining 32 PHPStan errors across tests and services Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * docs: enhance PHPStan type safety guidelines to prevent common errors Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Initial plan * Mark failing PHPUnit tests as incomplete Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Fix duplicate it_creates_template test method Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Implement all 20 incomplete test methods Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Remove all markTestIncomplete calls and add proper AAA structure to remaining tests Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Remove duplicate it_formats_document test that called non-existent format() method Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
… test inheritance (#328) * Initial plan * Fix Category 1 & 2: Create Settings view and fix SendInvoiceToPeppolActionTest database issues Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Add missing Settings view file Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
* Initial plan * fix: remove static keyword from $view property in DesignReportTemplate Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
…ons in factories, and add failed test group (#330) * Initial plan * Fix undefined variable $clients in ApiClient Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Fix NOT NULL constraint violations in factories - Add auto-resolution of customer_id/prospect_id in factories - Add auto-resolution of user_id in Invoice and Quote factories - Update DateFieldAutoPopulationTest to explicitly create customers - Fixes 157+ test failures related to missing required foreign keys Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Add @group failed annotations to failing tests - Add #[Group('failed')] to 20 failing test methods across 6 test files - Tests can now be run with: php artisan test --group=failed - No test logic modified, only annotations added Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Refactor DateFieldAutoPopulationTest to reduce duplication - Extract customer creation to createTestCustomer() helper method - Extract numbering creation to createTestNumbering() helper method - Replace 10 inline factory calls with helper methods - Follows coding guideline: reusable test logic in helper methods Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
* Initial plan * Fix PHPStan errors: add Group import and type hint for factory return Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
…es, and authentication (#332) * Initial plan * Fix test failures: correct field names, improve company filtering assertions, fix date helper assertions Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Fix numbering test by cleaning up default numberings created by CompanyObserver Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Fix NOT NULL constraint violations in factories and tests Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Fix Enum type errors in SettingsTest and API Client strict typing Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Fix Filament view failures by adding authentication to Settings tests Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add cleanup for default numberings in it_returns_empty_options_when_no_numberings_exist test Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Update Modules/Projects/Database/Factories/TaskFactory.php Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Initial plan * Consolidate documentation and optimize GitHub Actions with Composer caching Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Improve documentation clarity and composite action parameter descriptions Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Fix documentation clarity and relative links per review feedback Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
…tation with Laravel locale support (#337) * Initial plan * fix: Configure Crowdin credentials via workflow parameters instead of config file Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * refactor: Remove redundant environment variables from Crowdin workflow Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * docs: Add comprehensive documentation to crowdin.yml configuration Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * docs: Update crowdin.yml to use Laravel standard locale format with extensive documentation Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * feat: Apply %locale_with_underscore% placeholder and add language mapping configuration Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nielsdrost7
force-pushed
the
feature/126-implement-peppol
branch
from
42df80a to
b9ac17e
Compare
nielsdrost7
force-pushed
the
feature/126-implement-peppol
branch
from
faf4a67 to
ec5f51a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.