Fix Filament action imports, grid calculations, and refactor test mocks to fakes in Report Builder #351
+35
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback from #349 review: incorrect Filament action namespace usage, grid snapping calculation bug, test mock method mismatch, and Tailwind v4 syntax migration. Additionally refactors tests to use Storage fakes instead of mocks per project guidelines.
Changes
ReportBlocksTable.php
Filament\Tables\Actions\*instead ofFilament\Actions\*(page-level vs table-level)->recordActions()with->actions()for correct table APIarray $dataparameter from DeleteAction closureGridSnapperService.php
$xin width calculation instead of unclamped$position->getX()ReportTemplateServiceTest.php
Storage::fake('report_templates')following project guideline "Prefer Fakes and Fixtures over Mocks"ReportTemplateFileRepositoryinstance with faked storage layerit_persists_blocks()now validates actual file creation and content using Storage assertionsit_loads_blocks()now creates test fixtures usingStorage::put()instead of mocking return valuesinvoiceplane.css
!bg-primary-700→bg-primary-700!✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.