Making sure query string parameters are encoded#161
Merged
maikebing merged 2 commits intoIoTSharp:masterfrom May 6, 2025
Merged
Making sure query string parameters are encoded#161maikebing merged 2 commits intoIoTSharp:masterfrom
maikebing merged 2 commits intoIoTSharp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following error:
1.) Create a Job with a name containing a special character (I used

M&S)2.) Save it and return to
JobsIndex view.3.) For the newly created job, click on the dots and select
Copyfrom the menu.4.) The application errors out with 500 error.
This is because the Job's name is passed using query string which leads to unexpected behaviour if not handled carefully.
In this case the query string ended up being:
Which looks like
Swas another parameter without value. Instead, the correct way to passM&Sis:The same problem applies to triggers' names, which I also fixed in this PR.