Skip to content

fix #146#164

Merged
maikebing merged 1 commit intomasterfrom
#146
May 8, 2025
Merged

fix #146#164
maikebing merged 1 commit intomasterfrom
#146

Conversation

@maikebing
Copy link
Copy Markdown
Member

No description provided.

@maikebing maikebing requested a review from Copilot May 6, 2025 17:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #146 by ensuring that route URL concatenations correctly handle trailing slashes in the virtual path root. The changes update authentication paths, controller routes, and file server request paths to conditionally insert a slash if needed.

  • Updated login and access denied paths in ServiceCollectionExtensions.cs.
  • Modified controller route paths and file server request path in ApplicationBuilderExtensions.cs.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/SilkierQuartz/Configuration/ServiceCollectionExtensions.cs Adjusts authentication route paths for correct URL formatting.
src/SilkierQuartz/Configuration/ApplicationBuilderExtensions.cs Updates controller routes and file server path for consistent URL construction.
Comments suppressed due to low confidence (2)

src/SilkierQuartz/Configuration/ServiceCollectionExtensions.cs:44

  • [nitpick] The logic for conditionally appending a slash is repeated; consider extracting it into a helper method to improve maintainability and reduce duplication.
cfg.LoginPath = "${options.VirtualPathRoot}{(options.VirtualPathRoot.EndsWith('/') ? "" : "/")}Authenticate/Login";

src/SilkierQuartz/Configuration/ApplicationBuilderExtensions.cs:91

  • [nitpick] The conditional logic for ensuring the correct separator is repeated; extracting this logic into a shared utility could enhance code clarity and maintainability.
endpoints.MapControllerRoute(nameof(SilkierQuartz), "${options.VirtualPathRoot}{(options.VirtualPathRoot.EndsWith('/')?"":"/")}{controller=Scheduler}/{action=Index}");

@maikebing maikebing merged commit 3442993 into master May 8, 2025
1 check passed
@maikebing maikebing deleted the #146 branch May 8, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants