Support ClientCertificateSelectionCallback Issue #81#84
Open
Kevin-Andrew wants to merge 4 commits intoIonxSolutions:masterfrom
Open
Support ClientCertificateSelectionCallback Issue #81#84Kevin-Andrew wants to merge 4 commits intoIonxSolutions:masterfrom
Kevin-Andrew wants to merge 4 commits intoIonxSolutions:masterfrom
Conversation
Add support for the TCP mutual authentication to allow the client authentication certificate to be dynamically selected, via a callback method, upon each SSL connection. This allows for the rotation of a certificate without having to recreate and initialize an entire new TcpSyslogConfig. See IonxSolutions#81. The behavior of the CertificateProvider has essentially been updated to allow for the same thing. That is, if you specify a CertificateProvider, the Syslog Sink will now retrieve the Certificate property each time it establishes a connection. Before, it was only taking a copy of the certificate once, in the constructor, for the lifetime of the configuration.
Contributor
|
Looks great! If you can resolve the conflicts, I'll happily get this merged 👍 |
Contributor
Author
|
@colin-anderson , I resolved the conflict. That was caused by the other PR just being merged before this, since it happened to add a Unit Test as well. I then also updated the Take another look and then please do a "Squash and merge", as there is no point in keeping the extra, in-between commits, polluting the history. Then we can go ahead and mark Issue #81 as closed as well, I would say. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the TCP mutual authentication to allow the client authentication certificate to be dynamically selected, via a callback method, upon each SSL connection. This allows for the rotation of a certificate without having to recreate and initialize an entire new TcpSyslogConfig.
See #81.
The behavior of the CertificateProvider has essentially been updated to allow for the same thing. That is, if you specify a CertificateProvider, the Syslog Sink will now retrieve the Certificate property each time it establishes a connection. Before, it was only taking a copy of the certificate once, in the constructor, for the lifetime of the configuration.