Merged
Conversation
This can be observed with the newly added odometer PID, it wasn't getting exposed due to a gap of more than 0x20 (32) non-implemented ones While at it, add some typing hints and remove stray spaces Change-Id: If869ae1b90e2298bba01bd1aa418c6430014c221
For whatever reason, in [1], the LLM used added random 01 and 02 responses... [1]: 4fa71a3 Change-Id: Idd78504aaa5bbdb86ac43486d27eb6dd11689d7c
Per Wikipedia, OBD-II A6 PID should return 4 bytes, the LLM probably took inspiration from `CUSTOM_ODO` (given also the wrong PID) Change-Id: I1e86301857433bd04e6761d38ce073ea29673399
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.