Optimizes and Fix for DH fog toggle when shaders are disabled. #2634
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes DH fog settings only update if shader packs enabled/disabled state has changed since the prior frame and the DH Fog Enabled setting can be changed when no shader packs are enabled. Works with DH 2.2.1 and bugged for the upcoming DH 2.3.0 due to a bug with DH 2.3.0s' API with ClearValue(...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes DH fog settings only update if shader packs enabled/disabled state has changed since the prior frame and the DH Fog Enabled setting can be changed when no shader packs are enabled.
Note: Works with DH 2.2.1 without issues but bugged for the upcoming DH 2.3.0 due to a bug with DH 2.3.0s' API with ClearValue(...)