Make Orchestration 2.0 the default execution path#659
Merged
Conversation
Make Orch 2.0 the default for both UltraPlan and TripleShot sessions: - UltraPlan: flip UsePipeline default to true, routing execution through the pipeline backend instead of legacy ExecutionOrchestrator - TripleShot: wire teamwire.TeamCoordinator as default, replacing file polling with callback-driven execution via buffered channel bridge - Adversarial mode and session restoration stay on legacy path Add tripleshot.Runner interface for dual-coordinator coexistence, NewTripleShotAdapters() factory to break import cycles, and pipeline_wire.go wiring files for lazy PipelineRunner creation. Fix channel safety issues: nil-guard close to prevent double-close panic, stop re-subscribing after completion to prevent goroutine leak, close old channel on overwrite. Log SaveSession() errors instead of discarding. Improve pipeline factory error messages for users.
Iron-Ham
force-pushed
the
Iron-Ham/a403dd82-we-are-tackling-httpsgithubcom
branch
from
6911b9e to
5df7b74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UsePipelinedefault totrue, routing plan execution through the Orch 2.0 pipeline backend (Pipeline → team.Manager → Bridge) instead of the legacyExecutionOrchestrator. AddsExecutionRunnerinterface with factory-based injection to break import cycles.teamwire.TeamCoordinatoras the default execution path, replacing file-based polling with callback-driven execution via a buffered channel bridge into Bubble Tea. Falls back to legacy for adversarial mode or whentripleshot.use_legacyconfig is set.tripleshot.Runnerinterface for dual-coordinator coexistence,NewTripleShotAdapters()factory for cycle-safe adapter creation,pipeline_wire.gowiring files for lazyPipelineRunnerinstantiation, and 7 new Bubble Tea message types for teamwire events.SaveSession()errors (now logged), generic error messages (improved context), and missing session error details inPhaseFailedhandler.Test plan
go build ./...passesgo vet ./...passesgofmt -d .shows no outputgo test -race ./internal/orchestrator/...passes (coordinator pipeline path tests)go test -race ./internal/tui/...passes (view type changes, handler tests)go test -race ./internal/orchestrator/workflows/tripleshot/teamwire/...passesUsePipeline: true→ verify pipeline executestripleshot.use_legacy: true→ verify legacy path