Remove rand from proptests so consuming crates don't have to match the version of rand #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
It should be noted that this PR changes no code in the crate, only tests. Those tests could be generated in consuming crates, but it doesn't actually change the code generated. |
giarc3
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unnecessarily pushes the dev dependency onto all our users. It's not needed as we can use proptest to generate the random limbs and mask them off instead.
Also corrected an issue where if the PRIMEBITS was divisible by 31 or 62 the top limb would be 0 always (for the prop based tests).
Also made some changes to ensure more edge cases are being generated instead of leaving it up to chance. This helped find some issues with our tests that weren't ever exercised. (Division by 0)