Merged
Conversation
coltfred
requested changes
Apr 1, 2026
Member
coltfred
left a comment
There was a problem hiding this comment.
I pushed some changes I made as well as some tests. A couple thoughts as comments.
It's where it's needed, and it makes it so our message types make a little bit more sense and help document what's going on better.
coltfred
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #200
There's a lot of boilerplate to thread this through the Shim -> Frame -> Worker and back up, and a lot of test coverage. I added some examples of using it with files in an examples page on the website, I didn't want to bloat the library with the deps (and steps for it) for those to be in-lib helpers.
The main changes are (walking out from the core):
src/frame/worker/crypto/aes/StreamingAes.tsTransformStreams (which has its owntransformandflushthat theprocessChunkandfinalizeconcepts we need map nicely onto).src/frame/worker/DocumentCrypto.tssrc/frame/sdk/DocumentApi.ts&src/frame/sdk/DocumentAdvancedApi.tssrc/shim/sdk/DocumentSDK.tsHere's a generated flow diagram of decryptStream, hopefully it's helpful figuring out what's going on: