Skip to content

Update webpack et al #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 9, 2024
Merged

Update webpack et al #115

merged 8 commits into from
Sep 9, 2024

Conversation

skeet70
Copy link
Member

@skeet70 skeet70 commented Aug 26, 2024

In service of getting an updated version of micromatch for a stupid vulnerability that will never affect us.

skeet70 added 3 commits August 26, 2024 15:48
@skeet70
Get working nix environment for this repo
53c5d45
@skeet70
Update webpack, typescript, etc
50650b9 
All in service of being able to update micromatch.
Confirmed the dev server tests still run, everything still compiles with
these updates.
@skeet70
Update to fixed micromatch
7c8d4c2
@skeet70 skeet70 requested review from a team as code owners August 26, 2024 22:35
@skeet70 skeet70 requested review from giarc3 and removed request for a team August 26, 2024 22:35
@skeet70
Copy link
Member Author

skeet70 commented Aug 26, 2024

The change to remove wasm-bindgen's serde feature is because of https://rustwasm.github.io/wasm-bindgen/reference/arbitrary-data-with-serde.html#history.

@skeet70 skeet70 mentioned this pull request Sep 3, 2024
Closed
giarc3
giarc3 requested changes Sep 6, 2024
View reviewed changes
Copy link
Member

@giarc3 giarc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the new wasm-bindgen-Cargo.lock for?

Also, would it be okay for us to update puppeteer to "^22.8.2"? We're ~4 years behind and it won't run tests for me locally without updating it

@skeet70
Copy link
Member Author

skeet70 commented Sep 6, 2024 •
edited
Loading

wasm-bindgen-Cargo.lock was used in the flake.nix so it could install bindgen from source, but I don't think it's necessary now. I don't have a problem with someone updating puppeteer, whether in this PR or another. This PR was to get past a CVE (that didn't actually matter but is still causing dependabot build failures).

@skeet70 skeet70 merged commit 63d57ab into main Sep 9, 2024
1 check passed
@skeet70 skeet70 deleted the fix-micromatch-dep branch September 9, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giarc3 giarc3 giarc3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skeet70 @giarc3