Skip to content

Improve performance on struct.unpack #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Improve performance on struct.unpack #1817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6071a92
Improve performance on struct
slozier Nov 24, 2024
4c537a4
Fix some struct issues
slozier Nov 24, 2024
9abc993
Remove array overloads
slozier Nov 24, 2024
483e870
Clean up unpack_iterator
slozier Nov 24, 2024
e240d29
Fix packaging on .NET 9 SDK
slozier Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@

<!-- Release -->
<PropertyGroup Condition="'$(Configuration)' == 'Release'">
<DebugSymbols>false</DebugSymbols>
<DebugSymbols>true</DebugSymbols>
<DebugType>portable</DebugType>
<Optimize>true</Optimize>
<CheckForOverflowUnderflow>false</CheckForOverflowUnderflow>
Expand Down
4 changes: 0 additions & 4 deletions Src/IronPython.Modules/_ctypes/_ctypes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,10 +688,6 @@ private static IntPtr GetHandleFromObject(object dll, string errorMsg) {
return intPtrHandle;
}

private static void ValidateArraySizes(ArrayModule.array array, int offset, int size) {
ValidateArraySizes(array.__len__() * array.itemsize, offset, size);
}

private static void ValidateArraySizes(int arraySize, int offset, int size) {
if (offset < 0) {
throw PythonOps.ValueError("offset cannot be negative");
Expand Down
Loading