Support additional memory protection flag combinations #1864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slozier
approved these changes
Jan 6, 2025
Contributor
slozier
left a comment
slozier
left a comment
There was a problem hiding this comment.
It's a bit unfortunate about not being able to use sys.maxsize. Checking the 32/64-bitness seems to be one of its main uses. Perhaps we should change it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test is failing on my macOS (using Sequoia on ARM64). I have traced it to python/cpython#107888. I wonder what will happen on CI.
It turns out that
test_mmappasses on .NET 6.0 on Linux, but not on macOS. Go figure. Anyway, I've relaxed the test run condition accordingly.I have enabled some more tests that were marked TODO. It required some small and self-evident modifications to the test in StdLib. I've left comments at those places, in case there are some merge conflicts with later Python branches.