Isolate POSIX-specific native calls in PythonNT into separate file #1870
Conversation
| } | ||
|
|
||
| if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) { | ||
| if (!isWindows) { |
There was a problem hiding this comment.
Not really an issue since we're not calling native APIs here, but any idea if the platform analyzer would pick up on an isWindows variable and guard against Windows calls?
There was a problem hiding this comment.
As it is written now, no platform-specific calls are allowed in CheckFileAccessAndSize, regardless whether they are conditioned by isWindows in any way. .NET has SupportedOSPlatformGuardAttribute, but it cannot be applied to a parameter.
The reason why I replaced the platform check with a parameter is because having the platform test in this function was invalidating the platform context after the first call site, and I needed to make a call to PythonNT.dupUnix.
There was a problem hiding this comment.
Cool, didn't know (or forgot) that SupportedOSPlatformGuardAttribute existed.
Weird that iy breaks the platform check. Alternatively the parameter could be called allowGrow or something.
Src/IronPython.Modules/_winapi.cs
Outdated
| public static class PythonWinApi { | ||
| #region Public API | ||
|
|
||
| [SupportedOSPlatform("windows")] |
There was a problem hiding this comment.
Do we need the attribute on both the class and method?
2 participants
This adds platform guards to relevant functions in
PythonNT. By keeping them in a separate file I hope it will be easier to prevent omissions and inadvertent loads ofMono.Unixon Windows. Also, it makesnt.csjust a little bit smaller, which is always a good thing.