Skip to content

Conversation

@slozier
Copy link
Contributor

@slozier slozier commented Jan 25, 2025

I think this is the last set of changes before I merge into main. @BCSharp @Lamparter if you have any concerns please let me know.

@Lamparter
Copy link
Contributor

The namespaces should also be updated to match the project renames, for example:

- namespace IronPythonAnalyzer {
+ namespace IronPython.Analyzer {

@slozier
Copy link
Contributor Author

slozier commented Jan 25, 2025

The namespaces should also be updated to match the project renames

I updated a few of the namespaces. Note that I did not touch IronPythonTest on purpose as it would involve updating a lot of tests. If someone wants to tackle the tests later on I don't think I'll have any objections.

@Lamparter
Copy link
Contributor

I can give it ago once refactor is merged into main

Copy link
Member

@BCSharp BCSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@slozier slozier merged commit 2aca667 into IronLanguages:refactor Jan 26, 2025
8 checks passed
@slozier slozier deleted the rename_projects branch January 26, 2025 01:50
@slozier
Copy link
Contributor Author

slozier commented Jan 26, 2025

Alright, the merge into main is done. Thanks @Lamparter !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants