Fix conversions in _SimpleCData
#1912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BCSharp
changed the title
__index__ over __int__ in ModuleOps_SimpleCData
Member
Author
|
It started as simply preferring |
slozier
approved these changes
Feb 17, 2025
Contributor
slozier
left a comment
slozier
left a comment
There was a problem hiding this comment.
Not super familiar with this part of the codebase, but looks good to me.
| if (value is BigInteger) { | ||
| return (long)(BigInteger)value; | ||
| if (PythonOps.TryToInt(value, out BigInteger bi)) { | ||
| return unchecked((long)(ulong)(bi & ulong.MaxValue)); |
Contributor
There was a problem hiding this comment.
I guess this will no longer throw if the value is too big for a long. Not too familiar with these methods, but just confirming that this is the intended behaviour?
Contributor
There was a problem hiding this comment.
I guess test_conversions_overflow answers my question...
| } | ||
|
|
||
| private static void EmitInt64ToObject(ILGenerator method, LocalOrArg value) { | ||
| private static void EmitXInt64ToObject(ILGenerator method, LocalOrArg value) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides handling
__index__, it also better handlesBigIntegervalues, which are now Pythonint. This probably should have been done as part of #1329, but at that time I wasn't aware of this corner of the codebase.Also, there is a bunch of int/index conversions in
Converterthat partially overlap the conversions inPythonOps. I wonder it they could be consolidated somehow.