Enable nullable annotations in StructType and UnionType from ctypes #1921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slozier
approved these changes
Feb 25, 2025
| } | ||
|
|
||
| _fields = allFields.ToArray(); | ||
| _fields = [..allFields]; |
Contributor
There was a problem hiding this comment.
Interesting, never seen this syntax before. I haven't been keeping up with the more recent C# versions.
Not that I'm concerned about performance here, but is this smart enough to use ToArray (which is presumably more performant than a foreach statement)?
Member
Author
There was a problem hiding this comment.
but is this smart enough to use
ToArray
Yes, in this context it does, and in other contexts the compiler is allowed to do any other optimizations it is aware of. The .. operation is called now spread, which arguably is nicer than (but practically equivalent to) splat, which we discussed before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.