Use actual container type name for repr #1943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
repr()on the builtin container types for their subclasses to display the subclass name rather than always the root base type. Similarly what is already done forset:repr(set()isset()but ifclass MySet(set): passis defined,repr(MySet())isMySet(). The changed container types are:bytearrayarray.arraycollections.defaultdictcollections.dequeThis change has been implemented in Python 3.7. but in 3.4 - 3.6 there is one test in StdLib that catches the base class name; this has been upgraded here to the test from 3.7.