Conversation
Owner
|
Hey @Narzgul, Thank you for your interest in my project! I have looked into the changes you have made and have found some issues that would need to be resolved before I could consider merging your pull request:
Have a nice Sunday! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me start with excusing myself for this undocumented contribution and I am willing to continue explaining my changes if necessary.
This is the code I use to communicate to the Webuntis-API in my HUntis App. It is forked from this project and many of the changes are for adherence to the flutter code-style.
I however also have added some changes that could potentially clash with the usage of webuntis in other schools / institutions. Since I have only developed my app and by extension added to this project only with access to my schools system I can not check if it works for others.
I want to finish with expressing my gratitude to @IsAvaible for providing this project, because my app would not have been possible without it, which is why I want to give back by contributing!