Remove dead code and simplify core modules #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Delete 6 unused files never imported anywhere in the codebase: TaskClassifier.js (deprecated wrapper), EnhancedTaskClassifier.js (Node.js classifier with API support), ClassificationUtils.js, EnvironmentalUtils.js, DataStructure.js, DataStructureBrowser.js - Import TIERS from constants.js in ModelSelector.js instead of redefining it - BrowserTaskClassifier: merge identical preprocessText/normalizeKeyword into normalizeText, unify generateBigrams/generateTrigrams into generateNgrams, consolidate normalizePredictions/normalizeSubcategoryPredictions into shared normalizeScores method - EnvironmentalImpactCalculator: replace duplicate threshold checks with data-driven SCORE_TIERS lookup, remove unused singleton export All 91 tests pass, build succeeds. https://claude.ai/code/session_01QB4fvdE7X9NZsnfn74xet4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskClassifier.js (deprecated wrapper), EnhancedTaskClassifier.js (Node.js
classifier with API support), ClassificationUtils.js, EnvironmentalUtils.js,
DataStructure.js, DataStructureBrowser.js
normalizeText, unify generateBigrams/generateTrigrams into generateNgrams,
consolidate normalizePredictions/normalizeSubcategoryPredictions into shared
normalizeScores method
data-driven SCORE_TIERS lookup, remove unused singleton export
All 91 tests pass, build succeeds.
https://claude.ai/code/session_01QB4fvdE7X9NZsnfn74xet4