Skip to content

[MOB-10615] improve criteria update frequency #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
evantk91 merged 23 commits into from
Jan 29, 2025
Merged

[MOB-10615] improve criteria update frequency #863

evantk91 merged 23 commits into from
Jan 29, 2025

Conversation

@evantk91
Copy link
Contributor

@evantk91 evantk91 commented Jan 15, 2025 •
edited by atlassian bot
Loading

🔹 Jira Ticket(s) if any

✏️ Description

This pull request updates the criteria fetching to be done on foregrounding and adds a config flag to disable criteria fetching on foregrounding.

@evantk91 evantk91 marked this pull request as draft January 15, 2025 23:37
@evantk91 evantk91 marked this pull request as ready for review January 27, 2025 22:32
Ayyanchira
Ayyanchira approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great add on!

sumeruchat
sumeruchat approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@sumeruchat sumeruchat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor comments. Great job on adding unit tests.

Ayyanchira
Ayyanchira approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@Ayyanchira Ayyanchira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking Good. Added some nit pick

@evantk91 evantk91 merged commit 5a0b8dd into feature/itbl-track-anon-user Jan 29, 2025
3 of 4 checks passed
@evantk91 evantk91 deleted the evan/MOB-10615-improve-criteria-update-frequency branch January 29, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ayyanchira Ayyanchira Ayyanchira approved these changes

@sumeruchat sumeruchat sumeruchat approved these changes

@joaodordio joaodordio Awaiting requested review from joaodordio

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@evantk91 @Ayyanchira @sumeruchat