[MOB-10592] Add mobile network Info to register token request #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le SDK- Implement `IterableMobileFrameworkDetector` for detecting mobile frameworks (Flutter, React Native, Native).- Introduce `IterableMobileFrameworkInfo` to store framework type and SDK version.- Update `IterableConfig` to include mobile framework info.- Enhance device registration to include mobile framework data.- Add unit tests for framework detection and device registration.
…orkDetector• Combine framework class checks for improved detection accuracy.• Use BuildConfig.APPLICATION_ID for reliable package name verification.• Update comments for clarity.
…nd clarity- Introduced thread-safe caching for framework type detection.- Added `initialize` method for context setup and initial cache.- Separated detection logic into `detectFrameworkInternal`.- Enhanced framework class and metadata checks with lists.- Improved error handling and logging for unexpected scenarios.
…erableAPIMobileFrameworkType with IterableMobileFrameworkType.• Add @JvmStatic annotation to detectFramework method.• Use getPackageInfo instead of getApplicationInfo for metadata retrieval.• Update test cases to handle API level differences in PackageManager.• Improve error handling in framework detection logic.
sumeruchat
changed the title
…ed a lambda for class detection to improve flexibility.• Removed redundant hasClass method.• Updated tests to use reflection for modifying class detection.• Enhanced test setup with mock context initialization.• Simplified test cases for framework detection and caching logic.
…erableMobileFramework- Renamed `IterableMobileFrameworkInfo` to `IterableAPIMobileFrameworkInfo`- Renamed `IterableMobileFrameworkType` to `IterableAPIMobileFrameworkType`- Updated constructor and variable names accordingly
…framework identification
sumeruchat
force-pushed
the
feature/MOB-10592-add-mobile-framework-info
branch
from
5d686f4 to
8200a6d
Compare
…PIMobileFrameworkType- Updated class and variable names for consistency across the codebase.- Adjusted method signatures and test cases to reflect the new naming convention.
…ged hardcoded JSON keys to string literals for mobileFrameworkInfo.• Updated assertions to use direct string values for frameworkType and iterableSdkVersion.
…ged JSON key access from constants to string literals for `mobileFrameworkInfo`.- Updated assertions to use string literals for `frameworkType` and `iterableSdkVersion`.
…nfo handling- Updated `populateDeviceDetails` to accept `IterableAPIMobileFrameworkInfo` as an optional parameter.- Adjusted framework detection logic in `IterableApiClient` to handle null `mobileFrameworkInfo`.- Moved notification enabled check after framework info setup.- Renamed and reorganized constants in `IterableConstants`.- Enhanced `DeviceInfoUtils` to include framework info in device details if available.
…Update IterableApiClient to use IterableAPIMobileFrameworkType for framework detection.• Modify DeviceInfoUtils.populateDeviceDetails to include frameworkInfo.• Remove redundant mobile framework JSON construction in IterableApiClient.• Add import for IterableAPIMobileFrameworkInfo in DeviceInfoUtils.
… and DeviceInfoUtils- Cleaned up trailing whitespace in IterableApiClient.java and DeviceInfoUtils.java.- Ensured consistent formatting for better readability and maintainability.
sumeruchat
changed the title
…ace `println` with `IterableLogger.d` for consistent debug logging.- Use `IterableLogger.e` for error logging to improve error tracking.
…- Updated logging calls to use separate arguments for TAG and message.- Improved code readability and consistency in logging format.
…t comments and streamline code for clarity.
Ayyanchira
approved these changes
Jan 21, 2025
Comment on lines
+5
to
+9
| ## Unreleased | ||
|
|
||
| ### Added | ||
| - Added `mobileFrameworkInfo` configuration option to `IterableConfig` to identify the mobile framework (Flutter, React Native, or Native) being used with the SDK. | ||
|
|
Member
There was a problem hiding this comment.
Appreciating this! It usually was a task to figure out all changes and write it in one go at the end before release. This will definitely make release task lighter 👍🏼
| targetSdkVersion 31 | ||
|
|
||
| buildConfigField "String", "ITERABLE_SDK_VERSION", "\"3.5.7\"" | ||
| buildConfigField "String", "ITERABLE_SDK_VERSION", "\"3.5.9\"" |
Member
There was a problem hiding this comment.
This should be taken care by rebasing to master branch. This version is already out there.
Collaborator
Author
There was a problem hiding this comment.
In the master branch this is not set correctly @Ayyanchira
evantk91
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description
This PR adds mobile framework info support to the Android SDK, enabling tracking of framework usage in apps. The implementation includes:
Core Components:
IterableAPIMobileFrameworkTypeenum (FLUTTER, REACT_NATIVE, NATIVE)IterablAPIMobileFrameworkInfoclass for framework metadataIterableConfigfor setting framework infoDevice Registration:
Testing:
E2E Test
To test this PR just run the sdk with a native android app and then verify if the mobile framework info has been sent to the user device