-
Notifications
You must be signed in to change notification settings - Fork 33
[MOB-9340] Fix for removing recalled campaigns from device memory #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
59bf825
52f775e
4fda5df
1bb9810
3d7a03a
adfd8e6
d55ce26
9615c83
5eb2cb1
ecaba46
51a21cb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -321,6 +321,8 @@ public void handleInAppClick(@NonNull IterableInAppMessage message, @Nullable Ur | |
| synchronized void removeMessage(String messageId) { | ||
| IterableInAppMessage message = storage.getMessage(messageId); | ||
| if (message != null) { | ||
| // Mark message as consumed before removing it to prevent it from being displayed | ||
| message.setConsumed(true); | ||
|
Comment on lines
+324
to
+325
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if we need this |
||
| storage.removeMessage(message); | ||
| } | ||
| notifyOnChange(); | ||
|
|
@@ -365,7 +367,10 @@ private void syncWithRemoteQueue(List<IterableInAppMessage> remoteQueue) { | |
|
|
||
| for (IterableInAppMessage localMessage : storage.getMessages()) { | ||
| if (!remoteQueueMap.containsKey(localMessage.getMessageId())) { | ||
| // Mark message as consumed before removing it to prevent it from being displayed | ||
| localMessage.setConsumed(true); | ||
| storage.removeMessage(localMessage); | ||
| api.inAppConsume(localMessage, null, null, null, null); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lets get a confirmation from product to see if recalled message should be consumed. As it could affect the analytics. |
||
|
|
||
| changed = true; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets remove all the build and embedded related changes from this PR