SDK-307 Fix custom actions not working in background when SDK is not initialized #975
+87
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a push action with openApp=false is received before SDK initialization, the custom action handler was never invoked because getMainActivityContext() returned null. This fix: 1. Stores the application context early in handlePushAction() so getMainActivityContext() returns non-null even before initialize() is called 2. Only clears pendingAction if the action was actually handled, allowing deferred processing when SDK is initialized later with a customActionHandler This enables "snooze" type flows where a push button action with openApp=false can trigger a journey without requiring the full app to open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes custom actions not working when SDK is not initialized and
openApp=false. This enables "snooze" type push notification flows where a button action can trigger a journey without opening the app.Jira ticket: SDK-307
Changes
handlePushAction()sogetMainActivityContext()returns non-null even beforeinitialize()is calledpendingActionif the action was actually handled, allowing deferred processing when SDK is initialized later with acustomActionHandlerImpact
Testing
How to test:
openApp=falseand a custom action typeUnit tests added:
testBackgroundCustomActionWithNonInitializedSDK- verifies context is stored even without SDK inittestBackgroundCustomActionProcessedAfterSDKInit- verifies pending actions are processed after initialization