Skip to content

[SDK-368] Fix in-app creation causing crash due to problems with webview #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
franco-zalamena-iterable wants to merge 2 commits into
base: master
Choose a base branch
from
+21 −3
Open

[SDK-368] Fix in-app creation causing crash due to problems with webview #999

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
637e442
Fix webview missing crash on in-app creation
franco-zalamena-iterable Feb 25, 2026
ab9122b
Better error catching logic
franco-zalamena-iterable Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions ...ableapi/src/main/java/com/iterable/iterableapi/IterableInAppFragmentHTMLNotification.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import android.os.Bundle;
import android.os.Handler;
import android.os.Looper;
import android.util.AndroidRuntimeException;
import android.util.DisplayMetrics;
import android.view.Display;
import android.view.Gravity;
Expand Down Expand Up @@ -200,9 +201,12 @@
applyWindowGravity(getDialog().getWindow(), "onCreateView");
}

webView = new IterableWebView(getContext());
webView = createWebViewSafely(getContext());
if (webView == null) {
dismissAllowingStateLoss();
return null;
}
webView.setId(R.id.webView);

webView.createWithHtml(this, htmlString);

if (orientationListener == null) {
Expand Down Expand Up @@ -324,7 +328,9 @@
*/
@Override
public void onStop() {
orientationListener.disable();
if (orientationListener != null) {
orientationListener.disable();
}

super.onStop();
}
Expand Down Expand Up @@ -747,6 +753,15 @@
return InAppLayout.CENTER;
}
}

private IterableWebView createWebViewSafely(Context context) {
try {
return new IterableWebView(context);

Check warning

Code scanning / CodeQL

Android WebView settings allows access to content links Medium

Sensitive information may be exposed via a malicious link due to access to content:// links being allowed in this WebView.
} catch (AndroidRuntimeException e) {
Copy link
Member

@joaodordio joaodordio Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stack trace shows AndroidRuntimeException wrapping Resources$NotFoundException, but Resources.NotFoundException extends RuntimeException directly — not AndroidRuntimeException. If a future Android 16 patch changes the wrapping behavior (or a different OEM throws it unwrapped), this catch misses it entirely

Copy link
Contributor Author

@franco-zalamena-iterable franco-zalamena-iterable Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this was a point I was trying to consider, having it just looking for the Resources$NotFoundException was an option but then I was concerned other unexpected errors might occur, considering webView is an android implementation.

I can add a new more direct catch for the resources so we directly address that and then have this more generic one if a different problem occurs

IterableLogger.e(TAG, "Failed to create WebView", e);
return null;
}
}
}

enum InAppLayout {
Expand Down
Loading