Skip to content

Commit 3662ef3

Browse files
Merge pull request #7 from Iterable/feature/ITBL-5301-migrate-new-changes
[ITBL-5301] - migrate new changes
2 parents f12e0a7 + 9f77494 commit 3662ef3

File tree

140 files changed

+1937
-781
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

140 files changed

+1937
-781
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,4 @@ Pods/
1010

1111
scripts/
1212

13+
dev.config

IterableAppExtensions.podspec

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,14 @@ Pod::Spec.new do |s|
8585
# Not including the public_header_files will make all headers public.
8686
#
8787

88-
s.source_files = "notification-extension/*.{h,m,swift}", "swift-sdk/ITBConsts.swift"
88+
s.source_files = "notification-extension/*.{h,m,swift}", "swift-sdk/ITBConsts.swift", "swift-sdk/IterableConstants.h"
8989
# s.exclude_files = "Classes/Exclude"
9090

9191
# s.public_header_files = "Classes/**/*.h"
9292

93+
s.pod_target_xcconfig = {
94+
'SWIFT_VERSION' => '4.1'
95+
}
9396

9497
# ――― Resources ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― #
9598
#

IterableSDK.podspec

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,10 @@ Pod::Spec.new do |s|
7373

7474
s.source_files = "swift-sdk/*.{h,m,swift}"
7575

76+
s.pod_target_xcconfig = {
77+
'SWIFT_VERSION' => '4.1'
78+
}
79+
7680
# ――― Resources ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― #
7781
#
7882
# A list of resources included with the Pod. These are copied into the

Podfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
platform :ios, '8.0'
22

33
target 'swift-sdk-swift-tests' do
4-
pod 'OHHTTPStubs'
4+
pod 'OHHTTPStubs/Swift'
55
end
66

77
target 'swift-sdk-objc-tests' do

swift-sdk-objc-tests/IterableAPIResponseTests.m renamed to Tests/swift-sdk-objc-tests/IterableAPIResponseTests.m

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ @implementation IterableAPIResponseTests
2323

2424
- (void)setUp {
2525
[super setUp];
26-
[IterableAPI initializeWithApiKey:@"" launchOptions:nil config: nil email:nil userId:nil];
26+
[IterableAPI initializeWithApiKey:@""];
2727
}
2828

2929
- (void)tearDown {
@@ -56,8 +56,8 @@ - (void)testResponseCode200 {
5656

5757
XCTestExpectation *expectation = [[XCTestExpectation alloc] initWithDescription:@"onSuccess is called"];
5858

59-
NSURLRequest *request = [[IterableAPI instance] createPostRequestForAction:@"" withArgs:@{}];
60-
[[IterableAPI instance] sendRequest:request onSuccess:^(NSDictionary * _Nonnull data) {
59+
NSURLRequest *request = [[IterableAPI sharedInstance] createPostRequestForAction:@"" withArgs:@{}];
60+
[[IterableAPI sharedInstance] sendRequest:request onSuccess:^(NSDictionary * _Nonnull data) {
6161
[expectation fulfill];
6262
XCTAssert([data isEqualToDictionary:responseData]);
6363
} onFailure:nil];
@@ -69,8 +69,8 @@ - (void)testResponseCode200WithNoData {
6969

7070
XCTestExpectation *expectation = [[XCTestExpectation alloc] initWithDescription:@"onFailure is called"];
7171

72-
NSURLRequest *request = [[IterableAPI instance] createPostRequestForAction:@"" withArgs:@{}];
73-
[[IterableAPI instance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
72+
NSURLRequest *request = [[IterableAPI sharedInstance] createPostRequestForAction:@"" withArgs:@{}];
73+
[[IterableAPI sharedInstance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
7474
[expectation fulfill];
7575
XCTAssertEqualObjects(reason, @"No data received");
7676
}];
@@ -82,8 +82,8 @@ - (void)testResponseCode200WithInvalidJson {
8282

8383
XCTestExpectation *expectation = [[XCTestExpectation alloc] initWithDescription:@"onFailure is called"];
8484

85-
NSURLRequest *request = [[IterableAPI instance] createPostRequestForAction:@"" withArgs:@{}];
86-
[[IterableAPI instance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
85+
NSURLRequest *request = [[IterableAPI sharedInstance] createPostRequestForAction:@"" withArgs:@{}];
86+
[[IterableAPI sharedInstance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
8787
[expectation fulfill];
8888
XCTAssert([reason containsString:@"Could not parse json"]);
8989
}];
@@ -95,8 +95,8 @@ - (void)testResponseCode400WithoutMessage {
9595

9696
XCTestExpectation *expectation = [[XCTestExpectation alloc] initWithDescription:@"onFailure is called"];
9797

98-
NSURLRequest *request = [[IterableAPI instance] createPostRequestForAction:@"" withArgs:@{}];
99-
[[IterableAPI instance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
98+
NSURLRequest *request = [[IterableAPI sharedInstance] createPostRequestForAction:@"" withArgs:@{}];
99+
[[IterableAPI sharedInstance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
100100
[expectation fulfill];
101101
XCTAssert([reason containsString:@"Invalid Request"]);
102102
}];
@@ -108,8 +108,8 @@ - (void)testResponseCode400WithMessage {
108108

109109
XCTestExpectation *expectation = [[XCTestExpectation alloc] initWithDescription:@"onFailure is called"];
110110

111-
NSURLRequest *request = [[IterableAPI instance] createPostRequestForAction:@"" withArgs:@{}];
112-
[[IterableAPI instance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
111+
NSURLRequest *request = [[IterableAPI sharedInstance] createPostRequestForAction:@"" withArgs:@{}];
112+
[[IterableAPI sharedInstance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
113113
[expectation fulfill];
114114
XCTAssertEqualObjects(reason, @"Test error");
115115
}];
@@ -121,8 +121,8 @@ - (void)testResponseCode401 {
121121

122122
XCTestExpectation *expectation = [[XCTestExpectation alloc] initWithDescription:@"onFailure is called"];
123123

124-
NSURLRequest *request = [[IterableAPI instance] createPostRequestForAction:@"" withArgs:@{}];
125-
[[IterableAPI instance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
124+
NSURLRequest *request = [[IterableAPI sharedInstance] createPostRequestForAction:@"" withArgs:@{}];
125+
[[IterableAPI sharedInstance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
126126
[expectation fulfill];
127127
XCTAssertEqualObjects(reason, @"Invalid API Key");
128128
}];
@@ -134,8 +134,8 @@ - (void)testResponseCode500 {
134134

135135
XCTestExpectation *expectation = [[XCTestExpectation alloc] initWithDescription:@"onFailure is called"];
136136

137-
NSURLRequest *request = [[IterableAPI instance] createPostRequestForAction:@"" withArgs:@{}];
138-
[[IterableAPI instance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
137+
NSURLRequest *request = [[IterableAPI sharedInstance] createPostRequestForAction:@"" withArgs:@{}];
138+
[[IterableAPI sharedInstance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
139139
[expectation fulfill];
140140
XCTAssertEqualObjects(reason, @"Internal Server Error");
141141
}];
@@ -147,8 +147,8 @@ - (void)testNon200ResponseCode {
147147

148148
XCTestExpectation *expectation = [[XCTestExpectation alloc] initWithDescription:@"onFailure is called"];
149149

150-
NSURLRequest *request = [[IterableAPI instance] createPostRequestForAction:@"" withArgs:@{}];
151-
[[IterableAPI instance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
150+
NSURLRequest *request = [[IterableAPI sharedInstance] createPostRequestForAction:@"" withArgs:@{}];
151+
[[IterableAPI sharedInstance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
152152
[expectation fulfill];
153153
XCTAssert([reason containsString:@"Received non-200 response"]);
154154
}];
@@ -165,8 +165,8 @@ - (void)testNoNetworkResponse {
165165

166166
XCTestExpectation *expectation = [[XCTestExpectation alloc] initWithDescription:@"onFailure is called"];
167167

168-
NSURLRequest *request = [[IterableAPI instance] createPostRequestForAction:@"" withArgs:@{}];
169-
[[IterableAPI instance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
168+
NSURLRequest *request = [[IterableAPI sharedInstance] createPostRequestForAction:@"" withArgs:@{}];
169+
[[IterableAPI sharedInstance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
170170
[expectation fulfill];
171171
XCTAssert([reason containsString:@"NSURLErrorDomain"]);
172172
}];
@@ -183,9 +183,9 @@ - (void)testNetworkTimeoutResponse {
183183

184184
XCTestExpectation *expectation = [[XCTestExpectation alloc] initWithDescription:@"onFailure is called"];
185185

186-
NSMutableURLRequest *request = (NSMutableURLRequest *) [[IterableAPI instance] createPostRequestForAction:@"" withArgs:@{}];
186+
NSMutableURLRequest *request = (NSMutableURLRequest *) [[IterableAPI sharedInstance] createPostRequestForAction:@"" withArgs:@{}];
187187
request.timeoutInterval = 0.01;
188-
[[IterableAPI instance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
188+
[[IterableAPI sharedInstance] sendRequest:request onSuccess:nil onFailure:^(NSString * _Nonnull reason, NSData * _Nullable data) {
189189
[expectation fulfill];
190190
XCTAssert([reason containsString:@"timed out"]);
191191
}];

0 commit comments

Comments
 (0)