MOB-11657 Issues with timing of in app message display #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S 13+ multi-window support - Add iOS 13+ multi-window scene detection to IterableUtil.rootViewController - Prioritize foregroundActive scenes and key windows for InApp display - Maintain backward compatibility with iOS 12 and single-window apps - Fixes Stage Manager and multi-window scenarios on iPad
- Use scene.keyWindow property on iOS 15+ instead of isKeyWindow filter - isKeyWindow can return false for all windows on iOS 15+ with Stage Manager - Maintain iOS 13-14 compatibility with existing isKeyWindow approach - Resolves window detection issues in multi-window scenarios
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #925 +/- ##
===========================================
- Coverage 85.19% 68.91% -16.28%
===========================================
Files 91 104 +13
Lines 6301 7598 +1297
===========================================
- Hits 5368 5236 -132
- Misses 933 2362 +1429 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sumeruchat
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s)
✏️ Description
Problem 1: SDK needed a real-time control over when in-app messages can be displayed, rather than relying on the static isAutoDisplayPaused property.
Solution:
IterableInAppDisplayDelegateprotocol withisAutoDisplayPaused(for:)methodinAppDisplayDelegateproperty toIterableConfigInAppManager.isOkToShowNow()to call the delegate for real-time decision makingProblem 2: The 0.75-second delay happened after getting the view controller, causing issues when app state changed during the delay.
Solution:
InAppPresenterto change the timing sequence to: delay → check → get view controller → presentInAppDisplayerto defer view controller lookup and validation until after the delay