-
Notifications
You must be signed in to change notification settings - Fork 84
Expand CLAUDE.md with comprehensive inline documentation #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Replace brief reference to AGENT_README.md with complete inline documentation including build/test workflows, project structure, common task recipes, and AI agent memory system. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #995 +/- ##
==========================================
- Coverage 69.78% 69.77% -0.02%
==========================================
Files 111 111
Lines 8983 8983
==========================================
- Hits 6269 6268 -1
- Misses 2714 2715 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ayyanchira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some small optional suggestions. Would love to see how it makes difference 👍🏼
| - Create in `swift-sdk/Core/Models/YourModel.swift` | ||
| - Make it `@objcMembers public class` for Objective-C compatibility | ||
| - Implement `Codable` if it needs JSON serialization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice! More specific the expectation, better will be the output!
| ### 📍 Code Location Map | ||
| - **Auth Logic**: `swift-sdk/Internal/AuthManager.swift` (main auth manager), `swift-sdk/Internal/Auth.swift` (auth models) | ||
| - **API Calls**: `swift-sdk/Internal/api-client/ApiClient.swift` (main client), `swift-sdk/Internal/Network/NetworkHelper.swift` (networking) | ||
| - **Models**: `swift-sdk/Core/Models/` (all data structures - CommerceItem, IterableInAppMessage, etc.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably good to add Public facing methods go in IterableApi.swift class. Its implementation is in ApiClient.swift class.
What
Replaces the brief reference to AGENT_README.md with a complete, self-contained documentation file that AI agents can use directly without needing to read separate files.
Changes
Impact
Testing
How to test: