[SDK-234] Add real time updates to iOS #803
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (1)
🛟 Help
|
❌ 2 blocking issues (5 total)
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| if onEmbeddedMessageUpdatePresent || onEmbeddedMessagingDisabledPresent { | ||
| IterableAPI.embeddedManager.addUpdateListener(self) | ||
| } | ||
| } |
| * | ||
| * TODO: Figure out if this is purposeful | ||
| */ | ||
| // eslint-disable-next-line eqeqeq |
| */ | ||
| // eslint-disable-next-line eqeqeq | ||
| onEmbeddedMessagingDisabledPresent: | ||
| this.onEmbeddedMessagingDisabled != undefined, |
Ayyanchira
requested changes
Jan 13, 2026
src/core/classes/Iterable.ts
Outdated
Comment on lines
1093
to
1109
| if (Iterable.savedConfig.onEmbeddedMessageUpdate) { | ||
| RNEventEmitter.addListener( | ||
| IterableEventName.handleEmbeddedMessageUpdateCalled, | ||
| () => { | ||
| Iterable.savedConfig.onEmbeddedMessageUpdate?.(); | ||
| } | ||
| ); | ||
| } | ||
|
|
||
| if (Iterable.savedConfig.onEmbeddedMessagingDisabled) { | ||
| RNEventEmitter.addListener( | ||
| IterableEventName.handleEmbeddedMessagingDisabledCalled, | ||
| () => { | ||
| Iterable.savedConfig.onEmbeddedMessagingDisabled?.(); | ||
| } | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
if Iterable.savedConfig.embeddedMessagingEnabled ?
Then add both listners.
Comment on lines
+416
to
+430
| /** | ||
| * A boolean indicating if an embedded message update callback is present. | ||
| * | ||
| * TODO: Figure out if this is purposeful | ||
| */ | ||
| // eslint-disable-next-line eqeqeq | ||
| onEmbeddedMessageUpdatePresent: this.onEmbeddedMessageUpdate != undefined, | ||
| /** | ||
| * A boolean indicating if an embedded messaging disabled callback is present. | ||
| * | ||
| * TODO: Figure out if this is purposeful | ||
| */ | ||
| // eslint-disable-next-line eqeqeq | ||
| onEmbeddedMessagingDisabledPresent: | ||
| this.onEmbeddedMessagingDisabled != undefined, |
…terable configuration
…for-ios-and-andrio' into loren/embedded/SDK-234-ios-add-real-time-updates-and-track-message-rece
Ayyanchira
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 JIRA Ticket(s) if any
✏️ Description
Adds real time updates to iOS