-
Notifications
You must be signed in to change notification settings - Fork 42
[SDK-366] Parse media #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lposen
wants to merge
2
commits into
loren/embedded/SDK-366-new-parse-styles-for-components
Choose a base branch
from
loren/embedded/SDK-367-parse-media-for-components
base: loren/embedded/SDK-366-new-parse-styles-for-components
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+183
−33
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import type { IterableEmbeddedMessage } from '../../types/IterableEmbeddedMessage'; | ||
| import { IterableEmbeddedViewType } from '../../enums'; | ||
|
|
||
| /** | ||
| * This function is used to get the media to render for a given embedded view | ||
| * type and message. | ||
| * | ||
| * @param viewType - The type of view to render. | ||
| * @param message - The message to render. | ||
| * @returns The media to render. | ||
| * | ||
| * @example | ||
| * const media = getMedia(IterableEmbeddedViewType.Notification, message); | ||
| * console.log(media.url); | ||
| * console.log(media.caption); | ||
| * console.log(media.shouldShow ? 'true' : 'false'); | ||
| */ | ||
| export const getMedia = ( | ||
| /** The type of view to render. */ | ||
| viewType: IterableEmbeddedViewType, | ||
| /** The message to render. */ | ||
| message: IterableEmbeddedMessage | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| ) => { | ||
| if (viewType === IterableEmbeddedViewType.Notification) { | ||
| return { url: null, caption: null, shouldShow: false }; | ||
| } | ||
| const url = message.elements?.mediaUrl ?? null; | ||
| const caption = message.elements?.mediaUrlCaption ?? null; | ||
| const shouldShow = !!url && url.length > 0; | ||
| return { url, caption, shouldShow }; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| import { useMemo } from 'react'; | ||
|
|
||
| import { IterableEmbeddedViewType } from '../../enums'; | ||
| import type { IterableEmbeddedComponentProps } from '../../types/IterableEmbeddedComponentProps'; | ||
| import { getMedia } from './getMedia'; | ||
| import { getStyles } from './getStyles'; | ||
|
|
||
| /** | ||
|
|
@@ -11,7 +13,7 @@ import { getStyles } from './getStyles'; | |
| * @returns The embedded view. | ||
| * | ||
| * @example | ||
| * const \{ parsedStyles \} = useEmbeddedView(IterableEmbeddedViewType.Notification, \{ | ||
| * const \{ media, parsedStyles \} = useEmbeddedView(IterableEmbeddedViewType.Notification, \{ | ||
| * message, | ||
| * config, | ||
| * onButtonClick, | ||
|
|
@@ -20,6 +22,8 @@ import { getStyles } from './getStyles'; | |
| * | ||
| * return ( | ||
| * <View> | ||
| * <Text>\{media.url\}</Text> | ||
| * <Text>\{media.caption\}</Text> | ||
| * <Text>\{parsedStyles.backgroundColor\}</Text> | ||
| * </View> | ||
| * ); | ||
|
|
@@ -30,13 +34,18 @@ export const useEmbeddedView = ( | |
| /** The props for the embedded view. */ | ||
| { | ||
| config, | ||
| message, | ||
| }: IterableEmbeddedComponentProps | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| ) => { | ||
| const parsedStyles = useMemo(() => { | ||
| return getStyles(viewType, config); | ||
| }, [viewType, config]); | ||
| const media = useMemo(() => { | ||
| return getMedia(viewType, message); | ||
| }, [viewType, message]); | ||
|
|
||
| return { | ||
| parsedStyles, | ||
| media, | ||
| }; | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 2 issues:
1. Function with many returns (count = 5): IterableEmbeddedView [qlty:return-statements]
2. Function with high complexity (count = 11): IterableEmbeddedView [qlty:function-complexity]