Contact Information by chandms · Pull Request #20 · ItsForkIT/psync-pc

chandms · 2018-04-21T11:30:09Z

No description provided.

ghoshbishakh · 2018-04-21T17:24:23Z

src/main/java/bishakh/psync/Controller.java

                    }
                    else{
                        try {
-                            new Thread(fileTransporter.new ListFetcher(controller, new URL("http://"+s+":8080/list"), s)).start();


Just change this port while testing. Do not commit this change.

ghoshbishakh · 2018-04-21T17:24:41Z

src/main/java/bishakh/psync/Discoverer.java

@@ -1,5 +1,6 @@
 package bishakh.psync;

+import javax.swing.plaf.basic.BasicInternalFrameTitlePane;


ghoshbishakh · 2018-04-21T17:25:55Z

src/main/java/bishakh/psync/Discoverer.java

    public volatile ConcurrentHashMap<String, ArrayList<String>> priorityPeerList;
    public volatile ConcurrentHashMap<String, ArrayList<String>> originalPeerList;

-    public Discoverer(String BROADCAST_IP, String PEER_ID, int PORT, Logger LoggerObj,File ffile) {


fileName? what file name. use a better variable name please.

ghoshbishakh · 2018-04-21T17:26:01Z

src/main/java/bishakh/psync/FileTransporter.java

        if(!parent.exists() && !parent.mkdirs()){
            throw new IllegalStateException("Couldn't create dir: " + parent);
        }
-        URL fileUrl = new URL("http://"+ peerIP +":8080/getFile/" + fileID);


same here. port.

ghoshbishakh · 2018-04-21T17:26:36Z

src/main/java/bishakh/psync/SyncService.java

    private static String mapFileServerDirectory = "/home/alarm/DMS/";
    private static String databaseAndLogDirectory = "/home/alarm/DMS/";
    private static String databaseName = "fileDB.txt";
-    private static String contactFile = "contact.txt";


contactFileName or contactHistoryFileName

more descriptive name = better

ghoshbishakh · 2018-04-21T17:26:50Z

src/main/java/bishakh/psync/SyncService.java

        fileManager = new FileManager(PEER_ID, databaseName, databaseAndLogDirectory, syncDirectory, mapFileServerDirectory, logger);
        fileTransporter = new FileTransporter(syncDirectory, logger);
        controller = new Controller(discoverer, fileManager, fileTransporter, syncInterval, maxRunningDownloads, logger, 2, true);
-        webServer = new WebServer(8080, controller, logger);


ghoshbishakh · 2018-04-21T17:27:00Z

src/main/java/bishakh/psync/SyncService.java

        fileManager = new FileManager(PEER_ID, databaseName, databaseAndLogDirectory, syncDirectory, mapFileServerDirectory, logger);
        fileTransporter = new FileTransporter(syncDirectory, logger);
        controller = new Controller(discoverer, fileManager, fileTransporter, syncInterval, maxRunningDownloads, logger, 2, true);
-        webServer = new WebServer(8080, controller, logger);


ghoshbishakh · 2018-04-21T17:27:12Z

src/main/java/bishakh/psync/SyncService.java

        fileManager = new FileManager(PEER_ID, databaseName, databaseAndLogDirectory, syncDirectory, mapFileServerDirectory, logger);
        fileTransporter = new FileTransporter(syncDirectory, logger);
        controller = new Controller(discoverer, fileManager, fileTransporter, syncInterval, maxRunningDownloads, logger, priorityMethod, true);
-        webServer = new WebServer(8080, controller, logger);


ghoshbishakh · 2018-04-21T17:27:19Z

src/main/java/bishakh/psync/SyncService.java

        fileManager = new FileManager(PEER_ID, databaseName, databaseAndLogDirectory, syncDirectory, mapFileServerDirectory, logger);
        fileTransporter = new FileTransporter(syncDirectory, logger);
        controller = new Controller(discoverer, fileManager, fileTransporter, syncInterval, maxRunningDownloads, logger, priorityMethod, restrictedEpidemicFlag);
-        webServer = new WebServer(8080, controller, logger);


archie94

Documenting codes as you go along is always appreciated, but commenting out code lines adds no value. Kindly remove them.

archie94 · 2018-04-22T04:21:28Z

src/main/java/bishakh/psync/Discoverer.java

                    if(willUpdatePeer) {
                        String peerID = new String(datagramPacket.getData(), 0, datagramPacket.getLength());
                        updatePeers(datagramPacket.getAddress().getHostAddress(), peerID);
+                        /////////Added code


Remove unnecessary comments

archie94 · 2018-04-22T04:21:46Z

src/main/java/bishakh/psync/Discoverer.java

+                        writer.close();
+                        for(Map.Entry m:mp.entrySet())
+                        {
+                            //System.out.println(m.getKey()+" "+m.getValue());


Dont commit commented codes

archie94 · 2018-04-22T04:22:09Z

src/main/java/bishakh/psync/Discoverer.java

+                            printWriter.println(m.getKey()+" "+m.getValue());
+                        }
+                        printWriter.close();
+                        ////////////


Remove unnecessary comments

archie94 · 2018-04-22T04:22:27Z

src/main/java/bishakh/psync/SyncService.java

+    public SyncService() throws IOException {

-    public SyncService() {
+        //System.exit(0);


archie94 · 2018-04-22T04:22:44Z

src/main/java/bishakh/psync/SyncService.java

        databaseAndLogDirectory = baseDirectory;
        PEER_ID = inputPeerId;

+        //System.exit(0);


archie94 · 2018-04-22T04:23:18Z

src/main/java/bishakh/psync/SyncService.java

        databaseAndLogDirectory = baseDirectory;
        PEER_ID = inputPeerId;

+        //System.exit(0);


Remove commented codes.

archie94 · 2018-04-22T04:23:26Z

src/main/java/bishakh/psync/SyncService.java

-        syncDirectory = baseDirectory + File.separator + "sync" + File.separator;
+    public SyncService(String inputPeerId, String baseDirectory, int priorityMethod, boolean restrictedEpidemicFlag) throws IOException {
+
+        //System.exit(0);


ghoshbishakh · 2018-04-22T13:45:58Z

src/main/java/bishakh/psync/SyncService.java

-    public SyncService(String inputPeerId, String baseDirectory, int priorityMethod) {
-        syncDirectory = baseDirectory + File.separator + "sync" + File.separator;
+    public SyncService(String inputPeerId, String baseDirectory, int priorityMethod) throws IOException {
+        syncDirectory = baseDirectory +"sync" + "/";


? why this?

Suppose my baseDirectory is provided as "C:/Users/Desktop/WorkingDirectory/" (with a trailing '/').
So, no need to give File.separator after baseDirectory unless syncDirectory would be like "C:/Users/Desktop/WorkingDirectory/ \ sync".
And I just mentioned '/' instead of File.separator, it does not create problem.

Ok,
I just found this https://stackoverflow.com/questions/2417485/difference-between-file-separator-and-slash-in-paths

ok,
I just found this
https://stackoverflow.com/questions/2417485/difference-between-file-separator-and-slash-in-paths

Okay then I am replacing last '/' with File.separator

chandms added 5 commits April 21, 2018 16:48

Added Changes

08e9bfb

Added changes

5c3622e

Added Changes

7740ea9

New Changes

08ab4ff

Changed Including Contact

a78a074

ghoshbishakh requested changes Apr 21, 2018

View reviewed changes

Changes are done

83b9d1e

archie94 requested changes Apr 22, 2018

View reviewed changes

chandms added 2 commits April 22, 2018 10:27

Unnecessary comments are removed

8f11c64

Update Discoverer.java

c6ae90d

ghoshbishakh requested changes Apr 22, 2018

View reviewed changes

Update SyncService.java

c34b1c1

		@@ -1,5 +1,6 @@
		package bishakh.psync;

		import javax.swing.plaf.basic.BasicInternalFrameTitlePane;

Conversation

chandms commented Apr 21, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

archie94 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants