Skip to content

fix: prevent repeated text on reconnect by using block snapshots #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VibhorGautam wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent repeated text on reconnect by using block snapshots #1038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/lib/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ class SessionManager {
}

subscribe(listener: (event: string, data: any) => void): () => void {
const currentEventsLength = this.events.length;

const handler = (event: string) => (data: any) => listener(event, data);
const dataHandler = handler('data');
const endHandler = handler('end');
Expand All @@ -89,9 +87,23 @@ class SessionManager {
this.emitter.on('end', endHandler);
this.emitter.on('error', errorHandler);

for (let i = 0; i < currentEventsLength; i++) {
const { event, data } = this.events[i];
listener(event, data);
// Send the current state of each block as a snapshot rather than
// replaying every historical event. The old approach replayed all
// block creation + every incremental updateBlock patch, which caused
// reconnecting clients to visually rebuild (and effectively duplicate)
// content they had already received before the connection dropped.
for (const block of this.blocks.values()) {
listener('data', { type: 'block', block: structuredClone(block) });
}

// Replay any non-block milestone events (researchComplete, end, error)
// so reconnecting subscribers know if the session already finished.
for (const { event, data } of this.events) {
if (event === 'end' || event === 'error') {
listener(event, data);
} else if (event === 'data' && data.type === 'researchComplete') {
listener(event, data);
}
}

return () => {
Expand Down