Replace SemaphoreSlim with lock for file access #435
Merged
+34
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored BufferedFileLogStorage and FileLogStorage to use a simple object lock (_fileMutex) instead of SemaphoreSlim for synchronizing file access. This simplifies thread safety and removes unnecessary async/await patterns for file operations, improving maintainability.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Unity log file storage synchronization by replacing SemaphoreSlim with a simple lock/mutex object to coordinate file access, aiming to simplify thread safety and reduce async complexity.
Changes:
- Replaced
_fileLock(SemaphoreSlim) with_fileMutex(object) and converted critical sections tolockblocks. - Updated
Flush,Append,Clear, andQuerypaths to use the new lock-based synchronization. - Refactored async variants (
FlushAsync,AppendAsync) to removeWaitAsyncpatterns and adjust execution strategy.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Unity-MCP-Plugin/Assets/root/Runtime/Unity/Logs/FileLogStorage.cs | Replaces semaphore-based synchronization with lock and refactors async methods accordingly. |
| Unity-MCP-Plugin/Assets/root/Runtime/Unity/Logs/BufferedFileLogStorage.cs | Updates buffered flush/clear/query synchronization to use the base class mutex and changes FlushAsync behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored BufferedFileLogStorage and FileLogStorage to use a simple object lock (_fileMutex) instead of SemaphoreSlim for synchronizing file access. This simplifies thread safety and removes unnecessary async/await patterns for file operations, improving maintainability.