feat: User interface for AI agent configurations #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced McpClientConfiguratorRegistry to manage MCP client configurators. - Implemented dropdown selection for MCP clients in MainWindowEditor. - Updated ClientConfigPanel.uxml to include a dropdown for client selection. - Created individual configuration UXML files for various clients (Antigravity, Claude Code, Claude Desktop, Codex, Cursor, Gemini, VSCode Copilot, Visual Studio Copilot). - Enhanced MainWindowEditor to load and display client-specific configuration UI based on dropdown selection. - Added PlayerPrefs support to remember the selected MCP client across sessions.
- Updated titles and descriptions for Antigravity, Claude Code, Claude Desktop, Codex, Cursor, Gemini, and Visual Studio Copilot configurations. - Added manual configuration steps and troubleshooting sections to each client configuration. - Introduced a new CustomConfig.uxml for manual configuration options. - Adjusted test cases to use JsonAiAgentConfig instead of JsonClientConfig for consistency in MCP client configuration.
- Updated the UXML paths in various configurator classes to point to the new "agents" directory. - Enhanced the ClaudeCodeConfigurator to initialize terminal commands for configuration. - Added new UXML files for Antigravity, Claude Code, Claude Desktop, Codex, Cursor, Gemini, VSCode Copilot, and Visual Studio Copilot configurations. - Implemented a new Custom configuration UI for manual JSON input and Docker commands. - Improved foldout animations in the main window for better user experience.
- Added icon images for Antigravity, Claude Code, Claude Desktop, Codex, Cursor, Gemini, Visual Studio, and VS Code agents. - Updated the UI layout in the agent configuration panels to display agent icons alongside their names. - Modified the `AiAgentConfiguratorBase` class to include an abstract property for the icon file name and a method to set the agent icon. - Implemented the icon file name property in specific agent configurators. - Enhanced the UI styles to accommodate the new agent icons.
…onfiguration logic - Implement GeminiConfigurator for Gemini AI agent with UI elements and configuration handling. - Implement VisualStudioCodeCopilotConfigurator for GitHub Copilot in Visual Studio Code with UI elements and configuration handling. - Update AiAgentConfig and JsonAiAgentConfig to include ExpectedFileContent property for configuration validation. - Enhance UI styles and add new UXML files for Gemini and Visual Studio Code Copilot agents. - Modify existing UXML files for various agents to improve layout and add tutorial links. - Update troubleshooting instructions and configuration steps across multiple agent configurations.
…ons for MCP agents
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the MCP client configuration system into an extensible AI agent configuration UI framework. It introduces a dropdown-based interface allowing users to select and configure different AI agents (Claude Code, Claude Desktop, Visual Studio Code, Visual Studio, Cursor, Gemini, Antigravity, Codex, and a custom option).
Changes:
- Renamed core classes from
ClientConfig/JsonClientConfig/TomlClientConfigtoAiAgentConfig/JsonAiAgentConfig/TomlAiAgentConfigfor clearer semantics - Implemented a configurator pattern with
AiAgentConfiguratorBase, individual agent configurators, andAiAgentConfiguratorRegistry - Added comprehensive UXML templates for each AI agent with configuration instructions and status indicators
- Added gizmo icons for visual identification of AI agents in the UI
Reviewed changes
Copilot reviewed 69 out of 84 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
.vscode/settings.json |
Added "configurators" to spell checker dictionary |
Assets/root/Tests/Editor/UI/MainWindowEditor.ClientConfigureTests.cs |
Updated test references from JsonClientConfig to JsonAiAgentConfig |
Assets/root/Editor/UI/uxml/agents/*.uxml |
Added UXML templates for 9 different AI agent configurations |
Assets/root/Editor/UI/uxml/MainWindow.uxml |
Refactored to use dropdown-based agent selection instead of list-based approach |
Assets/root/Editor/UI/uxml/ClientConfigPanel.uxml |
Simplified to basic status/configure UI (moved from frame-group) |
Assets/root/Editor/UI/uss/common/*.uss |
Added styles for links, alerts, config snippets, agent icons, and title foldouts |
Assets/root/Editor/Scripts/UI/AiAgentConfigurators/*.cs |
Implemented configurator pattern with base class and 9 agent-specific implementations |
Assets/root/Editor/Scripts/Utils/AiAgentConfig/*.cs |
Renamed and enhanced config classes with ExpectedFileContent property |
Assets/root/Editor/Scripts/UI/Window/MainWindowEditor.*.cs |
Split client configuration into AiAgents.cs, made helper methods public/static |
Assets/root/Editor/Scripts/Startup.Server.cs |
Added RawTomlConfigurationStdio method, updated references to use AiAgentConfig |
Assets/root/Editor/Gizmos/ai-agents/* |
Added 64x64 PNG icons and meta files for 7 AI agents |
Unity-MCP-Plugin/Assets/root/Editor/UI/uxml/agents/CodexConfig.uxml
Outdated
Show resolved
Hide resolved
Unity-MCP-Plugin/Assets/root/Editor/UI/uxml/agents/CursorConfig.uxml
Outdated
Show resolved
Hide resolved
Unity-MCP-Plugin/Assets/root/Editor/Scripts/UI/Window/MainWindowEditor.AiAgents.cs
Show resolved
Hide resolved
Unity-MCP-Plugin/Assets/root/Editor/Scripts/UI/AiAgentConfigurators/AiAgentConfiguratorBase.cs
Show resolved
Hide resolved
…reflect correct formats
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 69 out of 84 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
Unity-MCP-Plugin/Assets/root/Editor/Scripts/Utils/AiAgentConfig/TomlAiAgentConfig.cs:51
- The command-line argument format has changed from
--port=toport=and from--plugin-timeout=toplugin-timeout=in the TOML configuration. This is a breaking change that will cause existing TOML configurations to fail.
The DoArgumentsMatch method in lines 280-283 checks for the new format port= and plugin-timeout=, but existing configurations may still use the old --port= format which won't be recognized. This will cause the IsConfigured check to return false for existing valid configurations and potentially create duplicate or incorrect configuration entries.
Consider either:
- Supporting both formats in the argument matching logic
- Providing a migration path for existing configurations
- Documenting this as a breaking change in the PR description and release notes
Unity-MCP-Plugin/Assets/root/Editor/Scripts/UI/AiAgentConfigurators/Impl/CustomConfigurator.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds meta files for several new gizmo icons related to AI agents in the Unity MCP Plugin project and updates the VSCode settings to include a new word in the spell checker dictionary. These changes help ensure proper asset importing and configuration within Unity, and improve the development environment.
Unity asset management:
.metafiles for new AI agent gizmo icons (antigravity-64.png,claude-64.png,codex-64.png,cursor-64.png,gemini-64.png,github-copilot-64.png,visual-studio-64.png) underAssets/root/Editor/Gizmos/ai-agents/, ensuring Unity recognizes and properly imports these textures. [1] [2] [3] [4] [5] [6] [7].metafile for theai-agentsfolder itself, supporting correct folder tracking by Unity.Development environment:
.vscode/settings.jsonto add"configurators"to the spell checker dictionary, reducing false positives for that term in code.