fix(cmap): accept metadata keys without leading slash in ToUnicode CMaps#475
Closed
abimaelmartell wants to merge 1 commit intoJ-F-Liu:mainfrom
Closed
fix(cmap): accept metadata keys without leading slash in ToUnicode CMaps#475abimaelmartell wants to merge 1 commit intoJ-F-Liu:mainfrom
abimaelmartell wants to merge 1 commit intoJ-F-Liu:mainfrom
Conversation
Contributor
Author
|
This was not a right approach, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some PDFs (e.g. EPEVER datasheets) emit CIDSystemInfo, CMapName, and CMapType without the leading
/in their ToUnicode CMap streams. The parser previously required the slash, causing these CMaps to fail parsing entirely and producing garbled text for Identity-H CID fonts.Updated CMap parser to accept CIDSystemInfo, CMapName, and CMapType with or without the leading / slash in ToUnicode CMap streams.
Thanks!