fix: fails to decode PDFDocEncoding-encoded Strings in metadata#477
Merged
J-F-Liu merged 2 commits intoJ-F-Liu:mainfrom Mar 13, 2026
Merged
fix: fails to decode PDFDocEncoding-encoded Strings in metadata#477J-F-Liu merged 2 commits intoJ-F-Liu:mainfrom
J-F-Liu merged 2 commits intoJ-F-Liu:mainfrom
Conversation
Owner
|
Thanks, please change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #459.
May also be related to #110.
Problem
The
Document::load_metadata()function does not decode the string correctly if it is encoded using PDFDocEncoding.According to PDF 1.7, Section 14.3.3, the type of title, author, etc., in the document information dictionary shall be a text string. That is,
Fix
use
common_data_structures::decode_text_string()to decode strings (#297)Example
Example PDF with a PDFDocEncoding-encoded document information dictionary:
http://mirrors.ctan.org/info/l2tabu/german/l2tabu.pdf
Code for test:
Result: (lopdf = "0.39.0")
Expected/Fixed:
Disclaimer
I am a complete beginner to Rust, so I'm unsure if this patch is appropriate. Please feel free to rewrite it if necessary.