fix(parser): accept trailing space in xref and startxref lines#485
Merged
J-F-Liu merged 1 commit intoJ-F-Liu:mainfrom Mar 29, 2026
Merged
Conversation
…ines
Some PDF generators emit trailing spaces on structural lines like
"xref \n" and "startxref \n". The xref subsection header already
handled this with opt(tag(" ")), but the xref keyword and startxref
keyword parsers did not, causing Xref(Start) errors on valid PDFs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xrefandstartxrefkeywordsxref \nandstartxref \nwith a trailing space before the newlineopt(tag(" "))— this applies the same treatment to the two keyword linesEncountered this in production, added some tests,
Thanks!