Skip to content

[pull] main from abuzuhri:main #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 5 commits into from
Oct 24, 2025
Merged

[pull] main from abuzuhri:main #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f002d4
Fixed null exception when SQS Queue is empty.
nicopizzo Oct 24, 2025
59a1570
Moved Thread.Sleep to stop from hammering SQS.
nicopizzo Oct 24, 2025
2a18f5b
Merge pull request #897 from nicopizzo/main
abuzuhri Oct 24, 2025
e3a514f
Fix fulfillment outbound currency serialization casing
abuzuhri Oct 24, 2025
e25ab8f
Merge pull request #899 from abuzuhri/codex/fix-parameter-casing-in-c…
abuzuhri Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Source/FikaAmazonAPI/AmazonSpApiSDK/Models/FulfillmentOutbound/Currency.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,16 @@ public Currency() { }
/// Three-digit currency code in ISO 4217 format.
/// </summary>
/// <value>Three-digit currency code in ISO 4217 format.</value>
[DataMember(Name = "CurrencyCode", EmitDefaultValue = false)]
[DataMember(Name = "currencyCode", EmitDefaultValue = false)]
[JsonProperty(PropertyName = "currencyCode")]
public string CurrencyCode { get; set; }

/// <summary>
/// The currency amount.
/// </summary>
/// <value>The currency amount.</value>
[DataMember(Name = "Value", EmitDefaultValue = false)]
[DataMember(Name = "value", EmitDefaultValue = false)]
[JsonProperty(PropertyName = "value")]
public string Value { get; set; }

/// <summary>
Expand Down
8 changes: 4 additions & 4 deletions Source/FikaAmazonAPI/Services/NotificationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,18 +136,18 @@ public async Task StartReceivingNotificationMessagesAsync(ParameterMessageReceiv
try
{
var result = await amazonSQSClient.ReceiveMessageAsync(receiveMessageRequest, cancellationToken);
var Messages = result.Messages;
var Messages = result.Messages ?? new List<Message>();
if (Messages.Count > 0)
{
foreach (var msg in Messages)
{
ProcessAnyOfferChangedMessage(msg, messageReceiver, amazonSQSClient, SQS_URL, isDeleteNotificationAfterRead, cancellationToken).ConfigureAwait(false);

}

if (Messages.Count < 10)
Thread.Sleep(1000 * 5);
}

if (Messages.Count < 10)
Thread.Sleep(1000 * 5);
}
catch (Exception ex)
{
Expand Down
Loading