Change branch order to fix MPI branching mismatch#98
Merged
mo-joshuacolclough merged 1 commit intofeature/bug_fix_interpolation_01from Mar 5, 2026
Conversation
odlomax
approved these changes
Mar 5, 2026
odlomax
left a comment
odlomax
left a comment
There was a problem hiding this comment.
Thanks for this, @mo-joshuacolclough!
mo-lormi
approved these changes
Mar 5, 2026
mo-joshuacolclough
merged commit cf0b069
into
feature/bug_fix_interpolation_01
45 of 47 checks passed
mo-joshuacolclough
deleted the
feature/fix_branch_ordering_spherical_vector
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue encountered with lfric-jedi 3dfgat_atms where some MPI ranks go down different
ifbranches. Changing the order so that the scalarMethodis returned first fixes the problem. Potentially the issue is due to checks thatMethodperforms that call halo exchanges. Returning early withMethodensures that the additional logic in SphericalVector does not interfere.Dependencies
For ecmwf/pull/351
Checklist