Fix to Surface pressure corrector WRFDA scheme when virtualTemperature observation is not present #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st without OBS virtualTemp and specificHumidity variable
rajichidamb
added
the
coordinate merge
Collaborator
BenjaminRuston
left a comment
BenjaminRuston
left a comment
There was a problem hiding this comment.
thanks @rajichidamb this is ready to move forward
BenjaminRuston
approved these changes
Nov 15, 2025
Collaborator
BenjaminRuston
left a comment
BenjaminRuston
left a comment
There was a problem hiding this comment.
thank you @rajichidamb file sizes are reasonable and tested with SpackStack v1.8 locally with gnu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Surface pressure operator WRFDA scheme code was looking for virtualTemperature ObsValue in observation, but according to https://jointcenterforsatellitedataassimilation-jedi-docs.readthedocs-hosted.com/en/latest/inside/jedi-components/ufo/obsops.html#id65 observed airTemperature and specificHumidity can be used to calculate in the absence. The code is updated and to perform unit test new observation files without variables are created.
jedi-ci-test-select=gcc
Issue(s) addressed
Resolves https://github.com/JCSDA-internal/ufo/issues/3820
Dependencies
https://github.com/JCSDA-internal/ufo/pull/3830
Impact
Test the bug fix
Checklist