Fix reference value to match calculated value due to updated epsilon constant #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huishao-r
approved these changes
Nov 21, 2025
Collaborator
huishao-r
left a comment
huishao-r
left a comment
There was a problem hiding this comment.
Great. I see the UFO tests have passed. Assume these data are correct then.
Thanks!
jcsda-bot
pushed a commit
to JCSDA/mpas-jedi
that referenced
this pull request
Nov 21, 2025
DESCRIPTION OF CHANGES: Issue JCSDA-internal/ufo#3530 pointed to repeating constants and missing units. Updating the file caused some test failures due to reference and test value mismatch, so updating the reference file. jedi-ci-test-select=gcc build-group=JCSDA-internal/ufo#3857 build-group=JCSDA-internal/ufo-data#518 build-group=JCSDA-internal/fv3-jedi#1435 build-group=JCSDA-internal/soca#1204 ISSUE: Fixes #JCSDA-internal/ufo#3530 LIST OF MODIFIED FILES: mpas-jedi/test/testoutput/ hofx3d.ref, 3dvar.ref, 3dvar_bumpcov.ref, 3dvar_bumpcov_nbam.ref, 3denvar_bumploc.ref, 3denvar_dual_resolution.ref, 3denvar_2stream_bumploc.ref, 3dhybrid_bumpcov_bumploc.ref, 4denvar_ID.ref, 4denvar_bumploc.ref, 4dhybrid_bumpcov_bumploc.ref, eda_3dhybrid.ref, lgetkf.ref TESTS CONDUCTED: ctest test_mpasjedi_hofx3d, test_mpasjedi_3dvar, test_mpasjedi_3dvar_bumpcov, test_mpasjedi_3dvar_bumpcov_nbam, test_mpasjedi_3denvar_bumploc, test_mpasjedi_3denvar_dual_resolution, test_mpasjedi_3denvar_2stream_bumploc, test_mpasjedi_3dhybrid_bumpcov_bumploc, test_mpasjedi_4denvar_ID, test_mpasjedi_4denvar_bumploc, test_mpasjedi_4dhybrid_bumpcov_bumploc, test_mpasjedi_eda_3dhybrid, test_mpasjedi_lgetkf_4pe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
src/ufo/variabletransforms/Cal_Humidity.cc file is updated to replace the constant of 0.622 with Constants::rd_over_rv, this caused a difference in calculated value, so updating the Test Reference value in the files.
Issue(s) addressed
Resolves #https://github.com/JCSDA-internal/ufo/issues/3508
#https://github.com/JCSDA-internal/ufo/issues/3530
Dependencies
Impact
Expected impact on downstream repositories:
Manual Testing Instructions (optional)
ctest -R ufo_test_tier1_test_ufo_variabletransforms_rhumidity
ctest -R ufo_test_tier1_test_ufo_variabletransforms_shumidity
ctest -R ufo_test_tier1_test_ufo_variabletransforms_shumidity2
Checklist