Skip to content

Adding instrument metadata to abi file#522

Merged
mikecooke77 merged 3 commits intodevelopfrom
feature/abiMetadataForDiffusion
Nov 6, 2025
Merged

Adding instrument metadata to abi file#522
mikecooke77 merged 3 commits intodevelopfrom
feature/abiMetadataForDiffusion

Conversation

@ncrossette
Copy link
Contributor

@ncrossette ncrossette commented Oct 28, 2025

Description

This adds metadata fields:

  	int instrumentIdentifier(Location) ;
  		instrumentIdentifier:_FillValue = -2147483648 ;
  	int satelliteIdentifier(Location) ;
  		satelliteIdentifier:_FillValue = -2147483648 ;

With values of 270 and 617 respectively so that the obs can be grouped and used by the WithinGroupCovariance Obs Error operator.

Issue(s) addressed

Resolves #521

No impact expected

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

fabiolrdiniz
fabiolrdiniz approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@fabiolrdiniz fabiolrdiniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ncrossette!

@fabiolrdiniz fabiolrdiniz added OBS OBS processing, UFO ALGO JEDI Algorithms needs review Asking others to review - often used for pull requests labels Oct 28, 2025
@ncrossette
Copy link
Contributor Author

ncrossette commented Oct 28, 2025

and thank you @fabiolrdiniz for the help on this!

rajichidamb
rajichidamb approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@rajichidamb rajichidamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nate.

@fabiolrdiniz fabiolrdiniz added ready for merge PR is reviewed and is ready for merge and removed needs review Asking others to review - often used for pull requests labels Oct 28, 2025
@ncrossette
Copy link
Contributor Author

ncrossette commented Nov 5, 2025 •
edited
Loading

@BenjaminRuston could you please merge this? When the CI is finished running?

@mikecooke77 mikecooke77 merged commit d5cbfeb into develop Nov 6, 2025
3 checks passed
@mikecooke77 mikecooke77 deleted the feature/abiMetadataForDiffusion branch November 6, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabiolrdiniz fabiolrdiniz fabiolrdiniz approved these changes

@rajichidamb rajichidamb rajichidamb approved these changes

@mikecooke77 mikecooke77 Awaiting requested review from mikecooke77

Assignees

@ncrossette ncrossette

Labels

ALGO JEDI Algorithms OBS OBS processing, UFO ready for merge PR is reviewed and is ready for merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add metadata for grouping

4 participants

@ncrossette @fabiolrdiniz @rajichidamb @mikecooke77