New data file to test the qc flag used in rttov interface #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding new group TestQcValue to the Obs file for testing purpose. This is just needed for testing since model will be providing the qc flag. When replacing the file testinput_tier_1/atms_n20_obs_20191230T0000_rttov.nc4 instead of creating new file testinput_tier_1/atms_n20_obs_20191230T0000_rttov_qc.nc4, I found some tests failing due to reference value mismatch -
The following tests failed
ufo_test_tier1_test_ufo_print_filter_data, ufo_test_tier1_test_ufo_print_filter_data_MPI2, ufo_test_tier1_test_ufo_print_filter_data_MPI3, ufo_test_tier1_test_ufo_print_filter_data_inefficient_distribution, ufo_test_tier2_test_ufo_atms_rttov_ops_qc_rttovonedvarcheck, ufo_test_tier1_test_ufo_function_bennartzscatindex
The following tests passed:
ufo_test_tier1_test_ufo_print_filter_data_MPI2_rank0
ufo_test_tier1_test_ufo_print_filter_data_time_window_selection
ufo_test_tier1_test_ufo_print_filter_data_time_window_selection_MPI2
So created a new obs file with new TestQcValue group.
Issue(s) addressed
Resolves #https://github.com/JCSDA-internal/ufo/issues/3265
Dependencies
List the other PRs that this PR is dependent on:
Impact
Expected impact on downstream repositories:
Manual Testing Instructions (optional)
If you would like your reviewers to manually build and test the change, please include
instructions on how the change should be built and tested. Also include a short
justification on why manual testing is necessary for this change.
Checklist