Disable py-numpy AVX512 instructions when compiled with Intel#498
Merged
climbfuji merged 2 commits intoJCSDA:spack-stack-devfrom Jan 14, 2025
Merged
Disable py-numpy AVX512 instructions when compiled with Intel#498climbfuji merged 2 commits intoJCSDA:spack-stack-devfrom
climbfuji merged 2 commits intoJCSDA:spack-stack-devfrom
Conversation
…47941) * Disable numpy AVX512 when compiled with Intel classic * Add py-numpy v1.26.5 * Add patch to handle AVX512 conversions * Remove unneeded patch. * Remove unnecessary tag * Move blas_config_settings to config_settings * Cleaned up blas settings
climbfuji
approved these changes
Jan 8, 2025
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Thanks for your diligence getting this into spack develop!
AlexanderRichert-NOAA
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This disables AVX512 instructions when compiling numpy with Intel classic compilers to prevent. The instructions produce NaNs when performing basic array operations. Further discussions can be found in
matplotlib/matplotlib#28762
numpy/numpy#27840
JCSDA/spack-stack#1276
Closes JCSDA/spack-stack#1276
Checklist