Update crtm(-fix), wgrib2#510
Conversation
* add crtm@3.1.1-build1 * fix url_for_version's version check Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com> --------- Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
AlexanderRichert-NOAA
requested review from
RatkoVasic-NOAA,
climbfuji and
srherbener
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
I don't know enough about the new wgrib2 build, but I refer to the experts and developers for that package. And if it's good enough for spack develop, then it is certainly good enough for us.
| spec = self.spec | ||
| if name == "cflags": | ||
| if spec.satisfies("%apple-clang"): | ||
| if self.spec.compiler.name == "apple-clang": |
There was a problem hiding this comment.
@AlexanderRichert-NOAA This seems to be a bug, or at least it is causing a build error? https://github.com/JCSDA/spack-stack/actions/runs/13077825823/job/36494196074?pr=1486
Maybe the compiler name is still clang, not apple-clang, even if the spec is apple-clang?
There was a problem hiding this comment.
Did you already take care of this? I can't test it, so feel free to do whatever makes work...
There was a problem hiding this comment.
My first attempt failed, I will need to look again. Unlikely I will be able to finish this today, other things are more urgent.
2 participants
This PR pulls in the crtm, crtm-fix, and wgrib2 updates included (or soon to be) in main Spack.
I checked out the files rather than cherry picking commits since the Spack commit will end up being different anyway...