Skip to content

Conversation

rickgrubin-noaa
Copy link
Collaborator

Add [email protected]; v2.8 and newer require dependency [email protected]: -- see here.

Deprecate [email protected] per communication with uwtools team. Deprecation policy: "latest three minor releases"

@rickgrubin-noaa rickgrubin-noaa self-assigned this Jul 18, 2025
@rickgrubin-noaa rickgrubin-noaa added enhancement New feature or request Epic For planning and administration labels Jul 18, 2025
@rickgrubin-noaa rickgrubin-noaa changed the title Uwtools Update uwtools Jul 18, 2025
@climbfuji
Copy link
Collaborator

@WeirAE Can you please review this? I recall vaguely problems with 2.8.x? Also, we want the version here to be in sync with the authoritative version in spack-packages.

@WeirAE
Copy link

WeirAE commented Jul 18, 2025

Just a nitpick and a technicality - thanks for putting the update in!

@rickgrubin-noaa
Copy link
Collaborator Author

@WeirAE Can you please review this? I recall vaguely problems with 2.8.x? Also, we want the version here to be in sync with the authoritative version in spack-packages.

@WeirAE update(s)? -- or waiting on upstream spack?

Copy link

@WeirAE WeirAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickgrubin-noaa Apologies - I added these but didn't click the 'submit review'!

@climbfuji
Copy link
Collaborator

Note that this PR will need to be recreated in https://github.com/jcsda/spack-packages to accommodate the changes coming with spack v1 and the separation of the packages repo. We don't want to make any updates to https://github.com/jcsda/spack until the update to spack v1 is completed.

@climbfuji climbfuji marked this pull request as draft August 5, 2025 16:46
@rickgrubin-noaa
Copy link
Collaborator Author

Note that this PR will need to be recreated in https://github.com/jcsda/spack-packages to accommodate the changes coming with spack v1 and the separation of the packages repo. We don't want to make any updates to https://github.com/jcsda/spack until the update to spack v1 is completed.

You prefer this PR to be closed and re-create / wait, correct?

@climbfuji
Copy link
Collaborator

It's ok to leave it open as a reminder for me to bring those changes over to spack-packages so that you don't have to repeat your work.

@climbfuji
Copy link
Collaborator

Let's ignore the windows audit failure; the audit worked on macOS and Linux.

@WeirAE and @rickgrubin-noaa can you please resolve the comments so that the package here looks like the one in JCSDA/spack-packages#1 ?

@rickgrubin-noaa
Copy link
Collaborator Author

Let's ignore the windows audit failure; the audit worked on macOS and Linux.

@WeirAE and @rickgrubin-noaa can you please resolve the comments so that the package here looks like the one in JCSDA/spack-packages#1 ?

Done.

@climbfuji
Copy link
Collaborator

This is ok to merge. See attached diff: left spack-packages (already merged), right this PR. I will note that the formatting in the spack-packages PR is not compliant and once we have the style check enabled it will fail. But that's not an issue at the moment.

image

@climbfuji climbfuji merged commit 29265cf into JCSDA:spack-stack-dev Aug 7, 2025
21 of 23 checks passed
@AlexanderRichert-NOAA
Copy link
Collaborator

This needs an update for py-python-dateutil, as no versions in the 2.9: range exist in the JCSDA repo. This is shown in the failing audit job: https://github.com/JCSDA/spack/actions/runs/16373480934/job/47606044798

@rickgrubin-tomorrow
Copy link

This needs an update for py-python-dateutil, as no versions in the 2.9: range exist in the JCSDA repo. This is shown in the failing audit job: https://github.com/JCSDA/spack/actions/runs/16373480934/job/47606044798

I'm aware of it; there is a 2.9.0-post0 version available; it's already in JCSDA/spack-packages for the day when the future becomes now.

In the meantime, pinning uwtools to 2.7.2 is part of a PR that will merge shortly -- a full build of spack-stack@develop succeeds and when that merges, this problem will go away.

Or I can update JCSDA/spack; you and @climbfuji can decide on how you'd like to proceed.

@climbfuji
Copy link
Collaborator

How about we pin uwtools for now?

@rickgrubin-noaa
Copy link
Collaborator Author

How about we pin uwtools for now?

Add uwtools for global-workflow-env, build openssl in the stack #1736 pins to [email protected] once approved / merged and Update uwtools #557 (which is merged) includes v2.7.2

@WeirAE
Copy link

WeirAE commented Aug 11, 2025

This will be good to add to the SRW environment too - I'll follow up with that once spack#1736 is merged and add to the weather model env as well once that integration progresses further

@rickgrubin-noaa rickgrubin-noaa deleted the uwtools branch August 19, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Epic For planning and administration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants