Add CI steps for restoring projects and create publish workflow for N… #185
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a NuGet publishing workflow and adds restore steps to the CI workflow. The publish workflow enables selective or batch publishing of NLog Azure extension packages to NuGet.org using GitHub's Trusted Publishing feature with OIDC authentication.
Key changes:
- New
publish.ymlworkflow that downloads artifacts from CI runs and publishes them to NuGet.org with support for dry runs - Added restore steps before pack and test operations in the CI workflow
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
.github/workflows/publish.yml |
New workflow for publishing packages to NuGet with manual triggering, artifact downloading from CI runs, and OIDC-based authentication |
.github/workflows/ci.yml |
Added restore steps before packing and testing operations in matrix jobs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/publish.yml
Outdated
| - name: List packages to publish | ||
| run: | | ||
| echo "Packages to publish:" | ||
| find packages -name "*.nupkg" -type f | while read f; do echo " - $(basename $f)"; done |
There was a problem hiding this comment.
The find command will produce no output and show no clear error message if the packages directory doesn't exist or contains no .nupkg files. This could happen if artifact downloads fail or the wrong run_id is provided. Consider adding error handling to check if any packages were found and fail with a clear message if not.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
* Initial plan * Add error handling for package discovery in publish workflow Co-authored-by: JDetmar <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JDetmar <[email protected]>
|
@copilot the action is failing |
* Initial plan * Fix publish.yml syntax error - move strategy matrix to proper structure Co-authored-by: JDetmar <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JDetmar <[email protected]>
…uGet