Fix invalid matrix strategy placement in publish workflow #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: JDetmar <[email protected]>
Copilot
AI
changed the title
[WIP] Add CI steps for NuGet publishing workflow
Fix invalid matrix strategy placement in publish workflow
Dec 13, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical YAML syntax error in the publish workflow where a strategy matrix was incorrectly placed inside a step definition. GitHub Actions requires strategy to be defined at the job level, not within individual steps. The fix reverts to explicit download steps for each of the 6 package artifacts, maintaining conditional logic for selective or bulk publishing.
Key Changes:
- Fixed invalid YAML syntax by replacing step-level matrix strategy with 6 explicit download steps
- Each download step includes proper conditionals based on
inputs.packageparameter - Added
actionlintto.gitignorefor workflow linting tool
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.gitignore |
Added actionlint (GitHub Actions workflow linter) to ignored files |
.github/workflows/publish.yml |
Replaced invalid step-level matrix strategy with 6 explicit artifact download steps, each with conditional logic for selective package publishing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: package-NLog.Extensions.AzureServiceBus | ||
| path: packages | ||
| github-token: ${{ github.token }} | ||
| run-id: ${{ steps.get-run-id.outputs.run_id }} |
There was a problem hiding this comment.
Missing blank line before this step. All other steps in the workflow are separated by blank lines for consistency and readability.
Suggested change
| run-id: ${{ steps.get-run-id.outputs.run_id }} | |
| run-id: ${{ steps.get-run-id.outputs.run_id }} |
JDetmar
added a commit
that referenced
this pull request
Dec 13, 2025
#185) * Add CI steps for restoring projects and create publish workflow for NuGet * Update .github/workflows/publish.yml Co-authored-by: Copilot <[email protected]> * Update .github/workflows/publish.yml Co-authored-by: Copilot <[email protected]> * Update .github/workflows/publish.yml Co-authored-by: Copilot <[email protected]> * Update .github/workflows/ci.yml Co-authored-by: Copilot <[email protected]> * Update .github/workflows/ci.yml Co-authored-by: Copilot <[email protected]> * Add error handling for missing packages in publish workflow (#186) * Initial plan * Add error handling for package discovery in publish workflow Co-authored-by: JDetmar <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JDetmar <[email protected]> * Fix invalid matrix strategy placement in publish workflow (#187) * Initial plan * Fix publish.yml syntax error - move strategy matrix to proper structure Co-authored-by: JDetmar <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JDetmar <[email protected]> * Add restore step for matrix projects in CI workflow --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions workflow was failing due to invalid YAML syntax - a
strategymatrix was placed inside a step definition instead of at the job level.Changes:
actionlintto.gitignoreContext:
The
strategykeyword in GitHub Actions must be defined at the job level, not within steps. Conditional artifact downloads based oninputs.packagerequire either separate steps or job-level matrix with complex conditionals. Chose separate steps for clarity and maintainability.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.