Skip to content

Fix invalid matrix strategy placement in publish workflow #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JDetmar merged 2 commits into from
Dec 13, 2025
Merged

Fix invalid matrix strategy placement in publish workflow #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ce7f5b
Initial plan
Copilot Dec 13, 2025
f9af9aa
Fix publish.yml syntax error - move strategy matrix to proper structure
Copilot Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 48 additions & 12 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,23 +54,59 @@ jobs:
echo "Using latest successful CI run: $RUN_ID"
fi

- name: Download package artifact
if: inputs.package == 'All' || inputs.package == matrix.package
- name: Download NLog.Extensions.AzureBlobStorage
if: inputs.package == 'All' || inputs.package == 'NLog.Extensions.AzureBlobStorage'
uses: actions/download-artifact@v4
with:
name: package-${{ matrix.package }}
name: package-NLog.Extensions.AzureBlobStorage
path: packages
github-token: ${{ github.token }}
run-id: ${{ steps.get-run-id.outputs.run_id }}

- name: Download NLog.Extensions.AzureDataTables
if: inputs.package == 'All' || inputs.package == 'NLog.Extensions.AzureDataTables'
uses: actions/download-artifact@v4
with:
name: package-NLog.Extensions.AzureDataTables
path: packages
github-token: ${{ github.token }}
run-id: ${{ steps.get-run-id.outputs.run_id }}

- name: Download NLog.Extensions.AzureQueueStorage
if: inputs.package == 'All' || inputs.package == 'NLog.Extensions.AzureQueueStorage'
uses: actions/download-artifact@v4
with:
name: package-NLog.Extensions.AzureQueueStorage
path: packages
github-token: ${{ github.token }}
run-id: ${{ steps.get-run-id.outputs.run_id }}

- name: Download NLog.Extensions.AzureEventGrid
if: inputs.package == 'All' || inputs.package == 'NLog.Extensions.AzureEventGrid'
uses: actions/download-artifact@v4
with:
name: package-NLog.Extensions.AzureEventGrid
path: packages
github-token: ${{ github.token }}
run-id: ${{ steps.get-run-id.outputs.run_id }}

- name: Download NLog.Extensions.AzureEventHub
if: inputs.package == 'All' || inputs.package == 'NLog.Extensions.AzureEventHub'
uses: actions/download-artifact@v4
with:
name: package-NLog.Extensions.AzureEventHub
path: packages
github-token: ${{ github.token }}
run-id: ${{ steps.get-run-id.outputs.run_id }}

- name: Download NLog.Extensions.AzureServiceBus
if: inputs.package == 'All' || inputs.package == 'NLog.Extensions.AzureServiceBus'
uses: actions/download-artifact@v4
with:
name: package-NLog.Extensions.AzureServiceBus
path: packages
github-token: ${{ github.token }}
run-id: ${{ steps.get-run-id.outputs.run_id }}
Copy link

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing blank line before this step. All other steps in the workflow are separated by blank lines for consistency and readability.

Suggested change
run-id: ${{ steps.get-run-id.outputs.run_id }}
run-id: ${{ steps.get-run-id.outputs.run_id }}

Copilot uses AI. Check for mistakes.
strategy:
matrix:
package:
- NLog.Extensions.AzureBlobStorage
- NLog.Extensions.AzureDataTables
- NLog.Extensions.AzureQueueStorage
- NLog.Extensions.AzureEventGrid
- NLog.Extensions.AzureEventHub
- NLog.Extensions.AzureServiceBus
- name: List packages to publish
run: |
echo "Packages to publish:"
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,3 +260,4 @@ paket-files/
__pycache__/
*.pyc
/src/nuget.exe
actionlint