Remove deprecated NLog.Extensions.AzureCosmosTable package #189
Conversation
- Remove all source files from AzureCosmosTable (deprecated, contains vulnerabilities) - Replace with placeholder README pointing to archive tag and migration path - Add DEPRECATED.md with deprecation status for AzureCosmosTable and legacy bundle - Add DEPRECATION_PROCESS.md to document deprecation workflow for future use The package depends on WindowsAzure.Storage which is unmaintained and has known security vulnerabilities. Users should migrate to NLog.Extensions.AzureDataTables. Source code preserved at tag: archive/azure-cosmos-table-2022-01-29 Refs: Snyk security findings
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated NLog.Extensions.AzureCosmosTable package from the default branch due to security vulnerabilities in its dependency chain (specifically the unmaintained WindowsAzure.Storage 9.3.3 package).
Key Changes:
- Removed all source code files for NLog.Extensions.AzureCosmosTable from the src directory
- Replaced with a placeholder README directing users to the archive tag and migration path to
NLog.Extensions.AzureDataTables - Added comprehensive deprecation documentation (
DEPRECATED.mdandDEPRECATION_PROCESS.md) to guide future deprecations
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/NLog.Extensions.AzureCosmosTable/TableStorageTarget.cs | Deleted main target implementation containing vulnerable dependencies |
| src/NLog.Extensions.AzureCosmosTable/NLogEntity.cs | Deleted entity class used by the target |
| src/NLog.Extensions.AzureCosmosTable/ICloudTableService.cs | Deleted service interface for cloud table operations |
| src/NLog.Extensions.AzureCosmosTable/Properties/AssemblyInfo.cs | Deleted assembly metadata |
| src/NLog.Extensions.AzureCosmosTable/NLog.Extensions.AzureCosmosTable.csproj | Deleted project file with vulnerable package references |
| src/NLog.Extensions.AzureCosmosTable/README.md | Replaced documentation with deprecation notice pointing to archive tag and migration alternative |
| DEPRECATED.md | Added comprehensive deprecation documentation for the removed package and legacy bundle |
| DEPRECATION_PROCESS.md | Added new process documentation to guide future package deprecations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ```markdown | ||
| # <PackageName> (removed) | ||
|
|
||
| This package was removed from the default branch because it is deprecated and contains known vulnerabilities. It is unmaintained and should not be used. See <AlternativePackage> instead. |
There was a problem hiding this comment.
The template text "It is unmaintained and should not be used" is missing a period compared to how it appears in the actual src/NLog.Extensions.AzureCosmosTable/README.md where it says "Do not use it." Consider standardizing the phrasing across templates and actual usage.
| ```markdown | ||
| # <PackageName> (removed) | ||
|
|
||
| This package was removed from the default branch because it is deprecated and contains known vulnerabilities. It is unmaintained and should not be used. See <AlternativePackage> instead. |
There was a problem hiding this comment.
The template says "contains known vulnerabilities. It is unmaintained" but the actual README in src/NLog.Extensions.AzureCosmosTable/README.md says "is deprecated, unmaintained, and contains known vulnerabilities". Consider aligning the template with the actual implementation or clarifying that templates are flexible examples.
| This package was removed from the default branch because it is deprecated and contains known vulnerabilities. It is unmaintained and should not be used. See <AlternativePackage> instead. | |
| This package was removed from the default branch because it is deprecated, unmaintained, and contains known vulnerabilities. It should not be used. See <AlternativePackage> instead. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Summary
Removes the deprecated
NLog.Extensions.AzureCosmosTablepackage source code from the default branch due to security vulnerabilities in its dependency chain.Changes
src/NLog.Extensions.AzureCosmosTable/DEPRECATED.mddocumenting deprecation statusDEPRECATION_PROCESS.mdfor future deprecation workflowsarchive/azure-cosmos-table-2022-01-29Reason
The package depends on
WindowsAzure.Storage9.3.3, which:Migration Path
Users should migrate to
NLog.Extensions.AzureDataTables, which uses the supportedAzure.Data.TablesSDK.References
archive/azure-cosmos-table-2022-01-29(commit f1c345b)DEPRECATED.mdGenerated following the deprecation process documented in
DEPRECATION_PROCESS.md